Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fromEvent): complete the stream after the first value on one time events #7439

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Deku-nattsu
Copy link

Description:
A small quality of life change to fromEvent when the once option is supplied, it makes sense to automatically close the stream after the first emission since the observable will only emit once. this will remove the need to manually unsubscribe every time you work with one time events.

BREAKING CHANGE:

Related issue (if exists):

@Deku-nattsu
Copy link
Author

oops i forgot about the case where you can pass an array of targets, i am setting this to draft for the moment

@Deku-nattsu Deku-nattsu marked this pull request as draft February 7, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant