Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insert method has so much resposability #9

Open
tonicospinelli opened this issue Mar 3, 2016 · 0 comments
Open

insert method has so much resposability #9

tonicospinelli opened this issue Mar 3, 2016 · 0 comments
Labels
enchancement

Comments

@tonicospinelli
Copy link
Member

The insert method needs a refactoring, the current behaviour is weird, it expects an object and adds an _id generated from database.

The correct behaviour should be return the inserted id and not fill id into object and Mapper get it and fill id from document object
@tonicospinelli tonicospinelli changed the title insert method has to much resposability insert method has so much resposability Mar 7, 2016
tonicospinelli added a commit to tonicospinelli/Structural that referenced this issue Mar 23, 2016
@tonicospinelli
change how to id is appended into object
c7f7db0 
this responsability was moved to Mapper, because the Mapper must know
how to id is defined.

fix Respect#9
tonicospinelli added a commit to tonicospinelli/Structural that referenced this issue Mar 23, 2016
@tonicospinelli
change how to id is appended into object
e523889 
this responsability was moved to Mapper, because the Mapper must know
how to id is defined.

fix Respect#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enchancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tonicospinelli