Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatch between ros gbp data and tags in source code #28

Open
kunaltyagi opened this issue Oct 14, 2020 · 3 comments
Open

Version mismatch between ros gbp data and tags in source code #28

kunaltyagi opened this issue Oct 14, 2020 · 3 comments

Comments

@kunaltyagi
Copy link

Steps to reproduce and error output

$ rosinstall_generator perception --rosdistro noetic --deps --upstream  > perception.rosinstall
$ vcs import --input perception.rosinstall ./src/
=== ./src/noetic/gennodejs (git) ===
Could not checkout ref '2.0.2': fatal: invalid reference: 2.0.2

Solution:

  • Add the 2.0.2 tag at the correct commit
  • Release a new version for noetic with the correct tag
@chris-smith
Copy link
Collaborator

@sloretz any suggestions on what to do here?

@IanTheEngineer and I had talked about doing an actual release at some point. I'm not sure what came up but we could prioritize doing so if that makes the most sense here.

@kunaltyagi
Copy link
Author

Another issue is the breakage on using --upstream option. It shows that somewhere on the ros release infra for this package, a crucial check is missing. Perhaps the person in charge of releasing gennodejs can help pinpoint the issue.

I'm not sure what came up but we could prioritize doing so if that makes the most sense here.

Adding a 2.0.3 tag to the latest (or future release) and a 2.0.2 tag retroactively would make most sense in accordance to semver

@sloretz
Copy link
Contributor

sloretz commented Oct 15, 2020

#25
ros/rosdistro#23711

@chris-smith I think a 2.0.3 release is the least effor path: ros/rosdistro#23711 (comment)

It might be possible to fast-forward from my fork of this repo and my fork of the release repo, but I don't know all the branches and tags that would need to be brought over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants