Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #39

Open
jvisenti opened this issue May 5, 2017 · 4 comments
Open

Improve test coverage #39

jvisenti opened this issue May 5, 2017 · 4 comments

Comments

@jvisenti
Copy link
Contributor

jvisenti commented May 5, 2017

screen shot 2017-05-05 at 11 16 06 am

Coverage as of 5/5/17
@jvisenti
Copy link
Contributor Author

Addressed in #42

@mpiechocki
Copy link
Contributor

Is there anything happening with this? I can see #42 is a really good PR but it's not merged. I don't know if I should open another PR with improved test coverage or just wait for #42 to be updated and merged.

@ZevEisenberg
Copy link
Collaborator

#42 is quasi-abandonware. It was created right as we were switching to Swift 4, and it never made the cut. If you're up for doing the work to port that PR, we'd greatly appreciate it! Feel free to branch from that branch, or start fresh. Thanks for the offer!

@ZevEisenberg
Copy link
Collaborator

Oh, and we have newer best practices for code coverage reporting at Raizlabs, mostly ushered in by @chrisballinger's work on the Raizlabs iOS template project and BonMot. Might want to look there for inspiration, because the codecov integration we did in #42 predates that later work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ZevEisenberg @jvisenti @mpiechocki