Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rux-accordion): CSS issue from Chrome upgrade #1358

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

FMorrison87
Copy link
Contributor

@FMorrison87 FMorrison87 commented Nov 13, 2024

Brief Description

This PR corrects a CSS issue with flex-direction and display on rux-accordion-item that was occurring in Chrome version 31.0.6778.70.

JIRA Link

Related Issue

General Notes

Motivation and Context

A user brought this issue to our attention.

Issues and Limitations

Types of changes

  • Bug fix
  • New feature
  • Breaking change

Checklist

  • This PR adds or removes a Storybook story.
  • I have added tests to cover my changes.
  • Regressions are passing and/or failures are documented
  • Changes have been checked in evergreen browsers

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 148bd15

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for astro-stencil ready!

Name Link
🔨 Latest commit 148bd15
🔍 Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/6734f70c29ed330008c41334
😎 Deploy Preview https://deploy-preview-1358--astro-stencil.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for astro-preview ready!

Name Link
🔨 Latest commit 148bd15
🔍 Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/6734f70cf286d60008d1113f
😎 Deploy Preview https://deploy-preview-1358--astro-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@micahjones13 micahjones13 merged commit 89c6be7 into main Nov 13, 2024
7 checks passed
@micahjones13 micahjones13 deleted the fm.accordion-fix branch November 13, 2024 20:08
@micahjones13
Copy link
Collaborator

Fixes issue: #1357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants