Skip to content

Commit 720c2db

Browse files
nesuprachynesuprachy
committed
DrD2LinkedTenacity patch 0.1.2
Performance optimization attempt
1 parent 677e68c commit 720c2db

File tree

3 files changed

+178
-60
lines changed

3 files changed

+178
-60
lines changed

‎DrD2LinkedTenacity/0.1.2/DrD2LinkedTenacity.js

+105
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,105 @@
1+
// Github: TBD
2+
// By: nesuprachy
3+
// Contact: https://app.roll20.net/users/11071738/nesuprachy
4+
//
5+
// This script tracks changes made to the `tenacity_current` attribute and propagates them to other sheets linked via the `npc_owner` attribute.
6+
// Uses ChatSetAttr mod to change attributes from chat https://github.com/Roll20/roll20-api-scripts/tree/master/ChatSetAttr#readme
7+
8+
var DrD2LinkedTenacity = DrD2LinkedTenacity || (function() {
9+
'use strict';
10+
11+
const version = '0.1.2';
12+
const lastUpdate = 1739435813976;
13+
// Global list of unarchived characters
14+
// Collect or refresh unarchived character list to avoid calling findObjs on every attribute change
15+
let allCharacters = [];
16+
const collectCharacters = () => {
17+
allCharacters = findObjs({
18+
_type: 'character',
19+
archived: false
20+
}, {caseInsensitive: true});
21+
};
22+
23+
// Gather all character IDs linked via 'npc_owner'
24+
// If change came from PC sheet, add NPCs whose 'npc_owner' attribute is same as originCharName
25+
// If change came from NPC sheet, add other NPCs with the same 'npc_owner' plus any PC whose name matches 'npc_owner'
26+
const gatherLinkedCharacters = (sheetType, originCharName, npcOwner) => {
27+
const targets = [];
28+
allCharacters.forEach( char => {
29+
const charName = char.get('name');
30+
const charNpcOwner = getAttrByName(char.id, 'npc_owner');
31+
32+
if(sheetType === 'pc' && originCharName) {
33+
if(charNpcOwner === originCharName) targets.push(char.id);
34+
}else if(sheetType === 'npc' && npcOwner) {
35+
if(charNpcOwner === npcOwner || charName === npcOwner) targets.push(char.id);
36+
}
37+
});
38+
return targets;
39+
},
40+
41+
checkInstall = function () {
42+
log(`-=> DrD2LinkedTenacity v${version} <=- [${new Date(lastUpdate)}]`);
43+
},
44+
45+
handleTenacityAttribute = function (obj, prev, isMax) {
46+
//const startTime = Date.now();
47+
48+
// Parse old and new values
49+
const prevVal = parseInt(isMax ? prev.max : prev.current) || 0;
50+
const newVal = parseInt(isMax ? obj.get('max') : obj.get('current')) || 0;
51+
if(newVal === prevVal) return;
52+
53+
// Retrieve origin character data
54+
const originCharId = obj.get('_characterid');
55+
const originChar = getObj('character', originCharId);
56+
const sheetType = getAttrByName(originCharId, 'sheet_type');
57+
const originCharName = originChar.get('name');
58+
const npcOwner = getAttrByName(originCharId, 'npc_owner');
59+
const targetChars = gatherLinkedCharacters(sheetType, originCharName, npcOwner);
60+
61+
/*log(`targetChars = ${targetChars}`);
62+
log(`sheet_type = \'${sheetType}\', npc_owner = \'${npcOwner}\'`);
63+
if(isMax) {
64+
log(`\'${obj.get('name')}\' (max) of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
65+
}else {
66+
log(`\'${obj.get('name')}\' of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
67+
}*/
68+
69+
if(Array.isArray(targetChars) && targetChars.length){
70+
const str = (isMax) ? `--tenacity_current||${newVal}` : `--tenacity_current|${newVal}`;
71+
sendChat('API', `!setattr --charid ${targetChars.join(",")} ${str} --silent --nocreate`, null, {noarchive:true});
72+
//log(`!setattr --charid ${targetChars.join(",")} ${str} --silent --nocreate`);
73+
}
74+
75+
//const endTime = Date.now();
76+
//log(`handleAttribute() took ${endTime - startTime} ms to execute`);
77+
},
78+
79+
registerEventHandlers = function () {
80+
on('add:character', function (){collectCharacters()});
81+
on('change:character:archived', function (){collectCharacters()});
82+
83+
on('change:attribute:current', function(obj, prev){
84+
if(obj.get('name') === 'tenacity_current') handleTenacityAttribute(obj, prev, false);
85+
});
86+
on('change:attribute:max', function(obj, prev){
87+
if(obj.get('name') === 'tenacity_current') handleTenacityAttribute(obj, prev, true);
88+
});
89+
};
90+
91+
return {
92+
CheckInstall: checkInstall,
93+
CollectCharacters: collectCharacters,
94+
RegisterEventHandlers: registerEventHandlers
95+
};
96+
97+
}());
98+
99+
on('ready', () => {
100+
'use strict';
101+
102+
DrD2LinkedTenacity.CheckInstall();
103+
DrD2LinkedTenacity.CollectCharacters();
104+
DrD2LinkedTenacity.RegisterEventHandlers();
105+
});

‎DrD2LinkedTenacity/DrD2LinkedTenacity.js

+70-57
Original file line numberDiff line numberDiff line change
@@ -8,77 +8,89 @@
88
var DrD2LinkedTenacity = DrD2LinkedTenacity || (function() {
99
'use strict';
1010

11-
const version = '0.1.1';
12-
const lastUpdate = 1725266705016;
13-
11+
const version = '0.1.2';
12+
const lastUpdate = 1739435813976;
13+
// Global list of unarchived characters
14+
// Collect or refresh unarchived character list to avoid calling findObjs on every attribute change
15+
let allCharacters = [];
16+
const collectCharacters = () => {
17+
allCharacters = findObjs({
18+
_type: 'character',
19+
archived: false
20+
}, {caseInsensitive: true});
21+
};
22+
23+
// Gather all character IDs linked via 'npc_owner'
24+
// If change came from PC sheet, add NPCs whose 'npc_owner' attribute is same as originCharName
25+
// If change came from NPC sheet, add other NPCs with the same 'npc_owner' plus any PC whose name matches 'npc_owner'
26+
const gatherLinkedCharacters = (sheetType, originCharName, npcOwner) => {
27+
const targets = [];
28+
allCharacters.forEach( char => {
29+
const charName = char.get('name');
30+
const charNpcOwner = getAttrByName(char.id, 'npc_owner');
31+
32+
if(sheetType === 'pc' && originCharName) {
33+
if(charNpcOwner === originCharName) targets.push(char.id);
34+
}else if(sheetType === 'npc' && npcOwner) {
35+
if(charNpcOwner === npcOwner || charName === npcOwner) targets.push(char.id);
36+
}
37+
});
38+
return targets;
39+
},
40+
1441
checkInstall = function () {
15-
log(`-=> DrD2LinkedTenacity v${version} <=- [${new Date(lastUpdate)}]`);
42+
log(`-=> DrD2LinkedTenacity v${version} <=- [${new Date(lastUpdate)}]`);
1643
},
1744

1845
handleTenacityAttribute = function (obj, prev, isMax) {
19-
if(obj.get('name') === 'tenacity_current') {
20-
var prevVal, newVal = 0;
21-
if(isMax){
22-
prevVal = parseInt(prev.max)||0;
23-
newVal = parseInt(obj.get('max'))||0;
24-
}else {
25-
prevVal = parseInt(prev.current)||0;
26-
newVal = parseInt(obj.get('current'))||0;
27-
}
28-
if(newVal !== prevVal) {
29-
var targetChars = [];
30-
var allCharacters = findObjs({
31-
_type: 'character',
32-
archived: false
33-
}, {caseInsensitive: true});
34-
var originChar = getObj('character', obj.get('_characterid'));
35-
var originCharName = originChar.get('name');
36-
var sheetType = getAttrByName(originChar.id, 'sheet_type');
37-
var npcOwner = getAttrByName(originChar.id, 'npc_owner');
38-
39-
if((sheetType === 'pc') && originCharName) {
40-
// If PC, add ID of every character owned by this PC to target characters array
41-
_.each(allCharacters, function(obj){
42-
if(getAttrByName(obj.id, 'npc_owner') === originCharName) {targetChars.push(obj.id)}
43-
});
44-
}else if ((sheetType === 'npc') && npcOwner) {
45-
// If NPC, add ID of every character with same 'npc_owner' to target characters array
46-
_.each(allCharacters, function(obj) {
47-
if(getAttrByName(obj.id, 'npc_owner') === npcOwner) {targetChars.push(obj.id)}
48-
});
49-
// Add sheets where 'character_name' equals 'npc_owner' to target characters array
50-
_.each(allCharacters, function(obj) {
51-
if(obj.get('name') === npcOwner) {targetChars.push(obj.id)}
52-
});
53-
}
46+
//const startTime = Date.now();
5447

55-
/*log(`sheet_type = \'${sheetType}\', npc_owner = \'${npcOwner}\'`);
56-
if(isMax) {
57-
log(`\'${obj.get('name')}\' (max) of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
58-
}else {
59-
log(`\'${obj.get('name')}\' of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
60-
}*/
48+
// Parse old and new values
49+
const prevVal = parseInt(isMax ? prev.max : prev.current) || 0;
50+
const newVal = parseInt(isMax ? obj.get('max') : obj.get('current')) || 0;
51+
if(newVal === prevVal) return;
6152

62-
if(Array.isArray(targetChars) && targetChars.length){
63-
if(isMax){
64-
//log(`!setattr --charid ${targetChars} --tenacity_current||${newVal} --silent --nocreate`);
65-
sendChat('API', `!setattr --charid ${targetChars} --tenacity_current||${newVal} --silent --nocreate`, null, {noarchive:true} );
66-
}else {
67-
//log(`!setattr --charid ${targetChars} --tenacity_current|${newVal} --silent --nocreate`);
68-
sendChat('API', `!setattr --charid ${targetChars} --tenacity_current|${newVal} --silent --nocreate`, null, {noarchive:true} );
69-
}
70-
}
71-
}
53+
// Retrieve origin character data
54+
const originCharId = obj.get('_characterid');
55+
const originChar = getObj('character', originCharId);
56+
const sheetType = getAttrByName(originCharId, 'sheet_type');
57+
const originCharName = originChar.get('name');
58+
const npcOwner = getAttrByName(originCharId, 'npc_owner');
59+
const targetChars = gatherLinkedCharacters(sheetType, originCharName, npcOwner);
60+
61+
/*log(`targetChars = ${targetChars}`);
62+
log(`sheet_type = \'${sheetType}\', npc_owner = \'${npcOwner}\'`);
63+
if(isMax) {
64+
log(`\'${obj.get('name')}\' (max) of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
65+
}else {
66+
log(`\'${obj.get('name')}\' of character \'${originCharName}\' changed from ${prevVal} to ${newVal}`);
67+
}*/
68+
69+
if(Array.isArray(targetChars) && targetChars.length){
70+
const str = (isMax) ? `--tenacity_current||${newVal}` : `--tenacity_current|${newVal}`;
71+
sendChat('API', `!setattr --charid ${targetChars.join(",")} ${str} --silent --nocreate`, null, {noarchive:true});
72+
//log(`!setattr --charid ${targetChars.join(",")} ${str} --silent --nocreate`);
7273
}
74+
75+
//const endTime = Date.now();
76+
//log(`handleAttribute() took ${endTime - startTime} ms to execute`);
7377
},
7478

7579
registerEventHandlers = function () {
76-
on('change:attribute:current', function(obj, prev){handleTenacityAttribute(obj, prev, false)});
77-
on('change:attribute:max', function(obj, prev){handleTenacityAttribute(obj, prev, true)});
80+
on('add:character', function (){collectCharacters()});
81+
on('change:character:archived', function (){collectCharacters()});
82+
83+
on('change:attribute:current', function(obj, prev){
84+
if(obj.get('name') === 'tenacity_current') handleTenacityAttribute(obj, prev, false);
85+
});
86+
on('change:attribute:max', function(obj, prev){
87+
if(obj.get('name') === 'tenacity_current') handleTenacityAttribute(obj, prev, true);
88+
});
7889
};
7990

8091
return {
8192
CheckInstall: checkInstall,
93+
CollectCharacters: collectCharacters,
8294
RegisterEventHandlers: registerEventHandlers
8395
};
8496

@@ -88,5 +100,6 @@ on('ready', () => {
88100
'use strict';
89101

90102
DrD2LinkedTenacity.CheckInstall();
103+
DrD2LinkedTenacity.CollectCharacters();
91104
DrD2LinkedTenacity.RegisterEventHandlers();
92105
});

‎DrD2LinkedTenacity/script.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"name": "DrD2LinkedTenacity",
33
"script": "DrD2LinkedTenacity.js",
4-
"version": "0.1.1",
5-
"previousversions": [],
6-
"description": "Designed for use only with the Draci Doupe II sheet.\n\nThis script tracks changes made to the `tenacity_current` attribute and propagates them to other sheets linked via the `npc_owner` attribute.",
4+
"version": "0.1.2",
5+
"previousversions": ["0.1.0", "0.1.1"],
6+
"description": "Designed for use only with the Draci Doupe II sheet.\n\nThis script tracks changes made to the `tenacity_current` attribute and propagates them to other sheets linked via the 'npc_owner' attribute.",
77
"authors": "nesuprachy",
88
"roll20userid": "11071738",
99
"useroptions": [],

0 commit comments

Comments
 (0)