Skip to content
This repository has been archived by the owner on Dec 3, 2017. It is now read-only.

Single quotes break timestamp edit shortcut #25

Open
roxaloxa opened this issue Oct 14, 2017 · 4 comments
Open

Single quotes break timestamp edit shortcut #25

roxaloxa opened this issue Oct 14, 2017 · 4 comments
Labels

Comments

@roxaloxa
Copy link
Contributor

If you click the timestamp on your own message that has a single quote in it like look at me, i'm gonna break!, then the command prompt will prefill with something like edit:10 look at me, i and truncate after the single quote.

screen shot 2017-10-13 at 10 57 07 pm

@roxaloxa
Copy link
Contributor Author

I saw your comment @neauoire about fixing this. I tested:

screen shot 2017-10-14 at 11 23 39 am

Looks like it removes apostrophes from the message, is that intended?

@neauoire
Copy link
Contributor

It's.. an improvement.

@neauoire
Copy link
Contributor

I'll try to make the htmlescape work.

@roxaloxa
Copy link
Contributor Author

roxaloxa commented Oct 14, 2017

What about the data-operation field just having like "edit:7" in it and when you click, it pulls the message itself from the local data after parsing the ID out?

Sticking the whole message in the attribute is kinda unwieldy

@lsjroberts lsjroberts added the bug label Oct 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants