Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token cannot be deleted with keyboard + no alternative text provided for delete token button #13083

Open
Slevunio opened this issue Mar 3, 2025 · 2 comments

Comments

@Slevunio
Copy link

Slevunio commented Mar 3, 2025

Is this a bug, enhancement, or feature request?
a bug

Describe your proposal.

‘Close/Delete’ button within the token is not keyboard accessible, there is no text alternative provided for this ‘Close/Delete’ button.

Can you handle that on the application side
No

Which versions of Angular and Fundamental Library for Angular are affected? Please, specify the exact version. (If this is a feature request, use current version.)
All

If this is a bug, please provide steps for reproducing it; the exact components you are using;

  1. open https://sap.github.io/fundamental-ngx/#/core/token
  2. press tab a couple of times
  3. observe that delete button within token is not focused - cannot be accesses with a keyboard + there is a default outline around token on focus (not fiori dotted border)

Please provide relevant source code (if applicable).
https://sap.github.io/fundamental-ngx/#/core/token

Please provide stackblitz example(s).
Any stackblitz example of token on official web page

In case this is Accessibility related topic, did you consult with an accessibility expert? If not, please do so and share their recommendations.
It was reported by accessibility expert

Did you check the documentation and the API?
yes

Did you search for similar issues?
yes

Is there anything else we should know?
nope

IMPORTANT: Please refrain from providing links or screenshots of SAP's internal information, as this project is open-source, and its contents are accessible to anyone.

@droshev
Copy link
Contributor

droshev commented Mar 10, 2025

@Slevunio Have you tested this in Multi input/Multi combobox or in a tokenizer? If you are not using those components, what is your scenarion and why do you need this?

@Slevunio
Copy link
Author

@droshev
We are using multi input but it doesn't work in any component that use tokenizer. The use case is that we allow user to choose multiple values from list. We'd also like to allow them to remove selected values in case of mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants