Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectPage: subSection Has Left and Right Padding Against Visual Design Spec #5850

Closed
1 task done
bomasap opened this issue May 24, 2024 · 2 comments · Fixed by #6494
Closed
1 task done

ObjectPage: subSection Has Left and Right Padding Against Visual Design Spec #5850

bomasap opened this issue May 24, 2024 · 2 comments · Fixed by #6494
Labels
bug Something isn't working released SAP SF

Comments

@bomasap
Copy link

bomasap commented May 24, 2024

Describe the bug

The subSection currently has left and right padding, which contradicts the visual design specification. According to the provided visual design spec (link below), the subSection should not have any left or right padding.
https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2697896853

Isolated Example

https://stackblitz.com/edit/github-t5j5mn-buqpel?file=src%2FApp.tsx,package.json

Reproduction steps

1.Open a stackblitz containing the subSection. https://stackblitz.com/edit/github-t5j5mn-buqpel?file=src%2FApp.tsx,package.json
2. Inspect the subSection element.
3. Objserve the presence of left and right padding.
...

Expected Behaviour

subSection should not have any left or right padding.

Screenshots or Videos

Screenshot 2024-05-24 at 1 14 48 PM

UI5 Web Components for React Version

1.28.4

UI5 Web Components Version

1.24.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v2.3.0 🎉

The release is available on v2.3.0

Your semantic-release bot 📦🚀

@ui5-webcomponents-react-bot
Copy link
Contributor

🎉 This issue has been resolved in version v1.29.12 🎉

The release is available on v1.29.12

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released SAP SF
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants