-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page build warning #184
Comments
GitHub updated the addresses for custom domains a while ago – I looked into it1 and you need to update them:
...then you'll hopefully be good to go! A cool side-effect of this is that in about a day, you'll be able to go into the site settings here and switch over to HTTPS 🤘 1: Based on |
Update: I've updated the IP addresses. Tomorrow I'll make a pull request to delete and re-add the CNAME file, after which we should be able to switch to HTTPS and close this issue 🎉 |
Cool! I just ran a build and didn't encounter this error. Also, sfpc.io now runs on HTTPS! Closing this issue. |
@rileyjshaw just opened #186 to fix a small issue related to this. |
We updated the site to HTTPS in #184, so resource protocols should match where available. I checked each of the changes to ensure they're all available over SSL, and they are! 🎉 I've also gotten rid of some protocol-relative URLs, since: > Now that SSL is encouraged for everyone and doesn’t have > performance concerns, this technique is now an anti-pattern. If the > asset you need is available on SSL, then always use the https:// > asset. - https://www.paulirish.com/2010/the-protocol-relative-url/ Test plan: - Ensure that each changed resource is available over HTTPS.
I got Page build warning after merging following PR.
#183 @pcsteppan
#181 @gregsadetsky
#178 @rileyjshaw
The page build completed successfully, but returned the following warning for the
master
branch:The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must update your site's DNS records if you'd like it to be available via your custom domain. For more information, see https://help.github.com/articles/using-a-custom-domain-with-github-pages/.
For information on troubleshooting Jekyll see:
https://help.github.com/articles/troubleshooting-jekyll-builds
The text was updated successfully, but these errors were encountered: