Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page build warning #184

Closed
tchoi8 opened this issue Feb 27, 2019 · 4 comments
Closed

Page build warning #184

tchoi8 opened this issue Feb 27, 2019 · 4 comments

Comments

@tchoi8
Copy link
Contributor

tchoi8 commented Feb 27, 2019

I got Page build warning after merging following PR.
#183 @pcsteppan
#181 @gregsadetsky
#178 @rileyjshaw

The page build completed successfully, but returned the following warning for the master branch:

The custom domain for your GitHub Pages site is pointed at an outdated IP address. You must update your site's DNS records if you'd like it to be available via your custom domain. For more information, see https://help.github.com/articles/using-a-custom-domain-with-github-pages/.

For information on troubleshooting Jekyll see:

https://help.github.com/articles/troubleshooting-jekyll-builds

@rileyjshaw
Copy link
Member

GitHub updated the addresses for custom domains a while ago – I looked into it1 and you need to update them:

  • Log in at https://www.gandi.net/en
  • Find your DNS settings page
  • You have an A record set up pointing to 192.30.252.154 (and maybe one to 192.30.252.153?) Update them. You probably need four A records pointing to:
    • 185.199.108.153
    • 185.199.109.153
    • 185.199.110.153
    • 185.199.111.153

...then you'll hopefully be good to go! A cool side-effect of this is that in about a day, you'll be able to go into the site settings here and switch over to HTTPS 🤘


1: Based on dig sfpc.io +answer it looks like your records are set up with Gandi and set to 192.30.252.154 (the old address).

@rileyjshaw
Copy link
Member

Update: I've updated the IP addresses. Tomorrow I'll make a pull request to delete and re-add the CNAME file, after which we should be able to switch to HTTPS and close this issue 🎉

@rileyjshaw
Copy link
Member

Cool! I just ran a build and didn't encounter this error. Also, sfpc.io now runs on HTTPS!

Screen Shot 2019-04-23 at 08 19 39

Closing this issue.

@gregsadetsky
Copy link
Contributor

@rileyjshaw just opened #186 to fix a small issue related to this.

rileyjshaw added a commit that referenced this issue Apr 24, 2019
We updated the site to HTTPS in #184, so resource protocols should
match where available. I checked each of the changes to ensure they're
all available over SSL, and they are! 🎉

I've also gotten rid of some protocol-relative URLs, since:

> Now that SSL is encouraged for everyone and doesn’t have
> performance concerns, this technique is now an anti-pattern. If the
> asset you need is available on SSL, then always use the https://
> asset.

- https://www.paulirish.com/2010/the-protocol-relative-url/

Test plan:

- Ensure that each changed resource is available over HTTPS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants