Skip to content

Commit 28239d6

Browse files
committed
scripts: switch back to dash for pre-releases
It turns out that git does not allow tilde in tag name therefore we need to keep using dash for upstream releases and tilde in downstream. Reviewed-by: Alexey Tikhonov <[email protected]>
1 parent fce2d97 commit 28239d6

File tree

3 files changed

+15
-8
lines changed

3 files changed

+15
-8
lines changed

contrib/sssd.spec.in

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# SSSD SPEC file for Fedora 34+ and RHEL-9+
22

3+
# Upstream version is using pre-release version with dash as a separator
4+
# since git does not support tilde in tag name. On the other side, Fedora and
5+
# RHEL requires tilde as a separator to correctly order builds.
6+
# For example: 2.10.0-beta1 vs 2.10.0~beta1
7+
%global upstream_version @PACKAGE_VERSION@
8+
%global downstream_version %(echo "@PACKAGE_VERSION@" | sed 's/-/~/g')
9+
310
# define SSSD user
411
%if 0%{?fedora} >= 41 || 0%{?rhel}
512
%global use_sssd_user 1
@@ -59,12 +66,12 @@
5966
%global samba_package_version %(rpm -q samba-devel --queryformat %{version}-%{release})
6067

6168
Name: @PACKAGE_NAME@
62-
Version: @PACKAGE_VERSION@
69+
Version: %{downstream_version}
6370
Release: 0@PRERELEASE_VERSION@%{?dist}
6471
Summary: System Security Services Daemon
6572
License: GPL-3.0-or-later
6673
URL: https://github.com/SSSD/sssd/
67-
Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz
74+
Source0: %{url}/archive/%{upstream_version}/%{name}-%{upstream_version}.tar.gz
6875
Source1: sssd.sysusers
6976

7077
### Patches ###
@@ -569,7 +576,7 @@ enable authentication with passkey token.
569576
%endif
570577

571578
%prep
572-
%autosetup -p1
579+
%autosetup -n %{name}-%{upstream_version} -p1
573580

574581
%build
575582

scripts/release.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function config()
77
}
88

99
SAVED_PWD=$PWD
10-
version=`grep '\[VERSION_NUMBER], \[.*\]' version.m4 | grep '[0-9]\+\.[0-9]\+\.[0-9]\+\(~[^]]\+\)\?' -o`
10+
version=`grep '\[VERSION_NUMBER], \[.*\]' version.m4 | grep '[0-9]\+\.[0-9]\+\.[0-9]\+\(-[^]]\+\)\?' -o`
1111
tag=${version}
1212

1313
trap "cd $SAVED_PWD; rm -rf sssd-${version} sssd-${version}.tar" EXIT

src/config/setup.py.in

+4-4
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ def sanitize_version(version):
3131
* https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
3232
* https://packaging.python.org/en/latest/discussions/versioning/
3333
"""
34-
# X.Y.Z~alpha1 -> X.Y.Za1
35-
# X.Y.Z~beta1 -> X.Y.Zb1
36-
# X.Y.Z~rc1 -> X.Y.Zrc1
37-
return version.replace('~', '').replace('alpha', 'a').replace('beta', 'b')
34+
# X.Y.Z-alpha1 -> X.Y.Za1
35+
# X.Y.Z-beta1 -> X.Y.Zb1
36+
# X.Y.Z-rc1 -> X.Y.Zrc1
37+
return version.replace('-', '').replace('alpha', 'a').replace('beta', 'b')
3838

3939
setup(
4040
name='SSSDConfig',

0 commit comments

Comments
 (0)