Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-opt-svfg have no effect #1497

Open
KelvinChung2000 opened this issue Jul 5, 2024 · 1 comment
Open

-opt-svfg have no effect #1497

KelvinChung2000 opened this issue Jul 5, 2024 · 1 comment

Comments

@KelvinChung2000
Copy link

Based on the help tooltip and the documentation, -opt-svfg should either remove formal-in/actual-out or ActualParm, AcutalIn and FormalRet, FormalOut. However, I have tried both -opt-svfg and -opt-svfg=false. The file they produce has the same number of lines, indicating that the optimisation has no effect.

I further checked the file generated by -opt-svfg and still see FormalINSVFGNode. Is this something that could happen, or is it expected all the FormalINSVFGNode should be removed? If this is something that could happen, what condition will lead to those nodes not being removed?

@yuleisui
Copy link
Collaborator

yuleisui commented Jul 5, 2024

If some functions are address-taken (being pointed by function pointers), their formalin will be retained. You could take a look at SVFOPT.cpp and debug a bit to see whether the methods handleInterValueFlow and handleIntraValueFlow being called or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants