Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no way to add borders to a drawer component #6803

Open
1 task done
elvis-iacobescu-sage opened this issue Jun 28, 2024 · 4 comments
Open
1 task done

There is no way to add borders to a drawer component #6803

elvis-iacobescu-sage opened this issue Jun 28, 2024 · 4 comments
Labels
Design System Review Required DS team to review changes Enhancement triage Triage Required

Comments

@elvis-iacobescu-sage
Copy link

elvis-iacobescu-sage commented Jun 28, 2024

Description

I have 2 components Breadcrumbs and a drawer component. The drawer has a 1px border top In the designs. Right now I have to do a workaround to be able to add a top border(<Hr my={0} >). We need a way to add borders to the box component or the drawer component designs.

Suggested solution

Add a border to the box Component or the Drawer component, or create a specific component that would be able to add borders around existing components

Demo URL

No response

Alternatives

No response

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@PaulSumner-Sage
Copy link
Contributor

I would suggest that the <Drawer /> component work when not "fullscreen" in an app and has the option to have a top/bottom border when required instead of another component required to make it look correct on a page

@edleeks87
Copy link
Contributor

@ljemmo and @harpalsingh thoughts on updating the designs for Drawer to support the above?

@edleeks87 edleeks87 added the Design System Review Required DS team to review changes label Jul 2, 2024
@ljemmo
Copy link
Contributor

ljemmo commented Aug 6, 2024

@elvis-iacobescu-sage please can you share a design via slack or teams for us to understand what this change would mean visually?

@nineteen88
Copy link
Contributor

@ljemmo @elvis-iacobescu-sage Hey both. Just chasing to see if you got anywhere further with this and if designs had been shared so a decision could be made? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design System Review Required DS team to review changes Enhancement triage Triage Required
Development

No branches or pull requests

5 participants