MenuItem - top/bottom padding added when contains node children #6934
Labels
Comments
edleeks87
changed the title
edleeks87
changed the title
|
FE-6798 |
edleeks87
added a commit
that referenced
this issue
Oct 14, 2024
…ht if any wrap to new lines Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new lines at smaller screen resolutions. Ensures no additonal padding is set on `MenuItem` children of `MenuFullscreen`. BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and `display` props. fix #6934, fix #7000
edleeks87
added a commit
that referenced
this issue
Oct 14, 2024
…ht if any wrap to new lines Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of `MenuFullscreen`. BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and `display` props. fix #6934, fix #7000
edleeks87
added a commit
that referenced
this issue
Oct 16, 2024
…ht if any wrap to new lines Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of `MenuFullscreen`. BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and `display` props. fix #6934, fix #7000
edleeks87
added a commit
that referenced
this issue
Oct 18, 2024
…ht if any wrap to new lines Ensures that `MenuItem`s flex so that they all have the same height if any wrap their content to new lines at smaller screen resolutions. Ensures no additional padding is set on `MenuItem` children of `MenuFullscreen`. BREAKING CHANGE: `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and `display` props. fix #6934, fix #7000
carbonci
pushed a commit
that referenced
this issue
Oct 21, 2024
## [144.0.0](v143.2.5...v144.0.0) (2024-10-21) ### ⚠ BREAKING CHANGES * **menu, menu-item:** `Menu` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `overflowY` and `display` props. `MenuItem` no longer supports `height`, `minHeight`, `maxHeight`, `size`, `verticalAlign`, `overflow`, `overflowY`, `overflowX` and `display` props. ### Bug Fixes * **menu-item:** ensure that it does not render children when `submenu` is an empty string ([975d5c6](975d5c6)), closes [#7010](#7010) * **menu, menu-item:** ensure that menu-items all remain the same height if any wrap to new lines ([501337c](501337c)), closes [#6934](#6934) [#7000](#7000)
|
🎉 This issue has been resolved in version 144.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Within
MenuFullscreenadditional top/bottom padding is being added to menu items that contain icons.Issue also present when
Pillpassed to item withhrefpropReproduction
MenuFullScreen
MenuItem with Pill and href
Steps to reproduce
Open fullscreen menu, inspect the menu items.
JIRA ticket numbers (Sage only)
SBS-108049
Suggested solution
No response
Carbon version
v142.9.0
Design tokens version
No response
Relevant browsers
Chrome
Relevant OSs
MacOS
Additional context
No response
Confidentiality
The text was updated successfully, but these errors were encountered: