Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better show methods which include AD info for stiff solvers #2156

Open
ArnoStrouwen opened this issue Mar 7, 2024 · 1 comment
Open

Better show methods which include AD info for stiff solvers #2156

ArnoStrouwen opened this issue Mar 7, 2024 · 1 comment

Comments

@ArnoStrouwen
Copy link
Member

The following two look the same:

julia> Rodas5P()
Rodas5P(; linsolve = nothing, precs = DEFAULT_PRECS,)
julia> sol.alg # comming from the default alg selector
Rodas5P(; linsolve = nothing, precs = DEFAULT_PRECS,)

But are not:

julia> typeof(Rodas5P())
Rodas5P{0, true, Nothing, typeof(OrdinaryDiffEq.DEFAULT_PRECS), Val{:forward}, true, nothing}

julia> typeof(sol.alg)
Rodas5P{1, false, Nothing, typeof(OrdinaryDiffEq.DEFAULT_PRECS), Val{:forward}, true, nothing}

It is super easy for the user to copy and paste the result from the show method and end up with a different solver.
The constructor with the autodiff keywords and so on should be printed instead.

@ChrisRackauckas
Copy link
Member

Interesting, I didn't know we had a show method on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants