Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please revert to ffi-rzmq, rbczmq gemspec is broken #42

Closed
mikofski opened this issue Jul 22, 2015 · 8 comments
Closed

please revert to ffi-rzmq, rbczmq gemspec is broken #42

mikofski opened this issue Jul 22, 2015 · 8 comments

Comments

@mikofski
Copy link

see methodmissing/rbczmq#41

@mikofski
Copy link
Author

well you're probably not going to do that so, is there anyway to get iruby on windows using Ruby Devkit?

@minad
Copy link
Contributor

minad commented Jul 22, 2015

Well, you just have to fix rbczmq.

Otherwise - the codehase allows to support both, ffi-rzmq and rbczmq. Take a look at the Session class which encapsulates the whole 0mq stuff. You can provide both implementations of the Session class if you want. For the ffi-rbzmq you just have to look at the history.

@minad
Copy link
Contributor

minad commented Jul 22, 2015

But I have to add, such a patch can only be accepted when I get a working test suite. Otherwise it is just getting out of hands.

@maxyeg
Copy link

maxyeg commented Sep 4, 2015

How can I revert to ffi-rzmq?

@v0dro
Copy link
Member

v0dro commented Sep 4, 2015

I've posted a possible fix to the rbczmq issue: methodmissing/rbczmq#41

Can someone with a Windows machine please try it out and see if it works?

@minad
Copy link
Contributor

minad commented Sep 5, 2015

Test

Am 4. September 2015 18:13:06 MESZ, schrieb Maxim [email protected]:

How can I revert to ffi-rzmq?


Reply to this email directly or view it on GitHub:
#42 (comment)

@jmarrec
Copy link

jmarrec commented Sep 24, 2015

This is still a problem by the way, doesn't seem to be getting much traction on methodmissing/rbczmq#41 either.

@domitry
Copy link
Member

domitry commented Nov 18, 2015

I installed rbczmq to Windows, but it doesn't work. (methodmissing/rbczmq#52)

I myself didn't try on Mac or FreeBSD, but I heard that installing fails on both environments.
(methodmissing/rbczmq#42, http://d.hatena.ne.jp/msll/20151116)

I think that adding compatibility with ffi-rzmq and removing rbczmq from runtime_dependency is better. (As pry is still in "recommended gems")

@minad minad closed this as completed Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants