Skip to content

Commit 567903e

Browse files
fix: return a cleanup function from PopupPage's useEffect hook (#110)
1 parent 2832671 commit 567903e

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/assets/ts/popup.tsx

+8-4
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,15 @@ const PopupPage: React.FC = () => {
3737
useEffect(() => {
3838
dispatch(signIn());
3939

40-
document.addEventListener('set-asset-dashboard-link', ((
41-
event: CustomEvent,
42-
) => {
40+
const handleAssetDashboardLink = ((event: CustomEvent) => {
4341
setAssetDashboardLink(event.detail);
44-
}) as EventListener);
42+
}) as EventListener;
43+
44+
document.addEventListener('set-asset-dashboard-link', handleAssetDashboardLink);
45+
46+
return () => {
47+
document.removeEventListener('set-asset-dashboard-link', handleAssetDashboardLink);
48+
};
4549
}, []);
4650

4751
return (

0 commit comments

Comments
 (0)