Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel: Support Meteor Lake memory map #25725

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Kernel: Support Meteor Lake memory map #25725

merged 2 commits into from
Feb 26, 2025

Conversation

phcoder
Copy link
Contributor

@phcoder phcoder commented Feb 24, 2025

On my darp10-b the memory map ends up breaking the early init routines. Here are the fixes

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Feb 24, 2025
Copy link
Contributor

@Hendiadyoin1 Hendiadyoin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small notes, otherwise LGTM, ig

@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@phcoder phcoder force-pushed the mem branch 2 times, most recently from 7908eae to 575a16b Compare February 24, 2025 10:15
On Meteor Lake this range covers the GFX address space reservations,
at a very high address. Nothing actually ends up using it, so we can
ignore it. Moreover if we don't we end up with highest_address at the
4 TiB mark which would need an enormous page table to map this
huge (0-4TiB) range. Until we support mapping I/O space piecewise we
need to skip this range.
When running with 32GiB of system RAM, 2MiB is not enough for the
page usage bitmap. New value should be enough for 128GiB of RAM
@spholz spholz added ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed and removed 👀 pr-needs-review PR needs review from a maintainer or community member labels Feb 26, 2025
@spholz spholz merged commit b336afa into SerenityOS:master Feb 26, 2025
14 checks passed
@github-actions github-actions bot removed the ✅ pr-maintainer-approved-but-awaiting-ci PR has been approved by a maintainer and can be merged after CI has passed label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants