Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: using diffopt+=vertical produces error when starting vim #24

Closed
djagellon opened this issue Oct 5, 2021 · 5 comments · Fixed by #25
Closed

Bug: using diffopt+=vertical produces error when starting vim #24

djagellon opened this issue Oct 5, 2021 · 5 comments · Fixed by #25
Assignees

Comments

@djagellon
Copy link

djagellon commented Oct 5, 2021

Not sure if this is considered a bug on our end since the error occurs with certain versions of macOS.

Starting with Catalina, the vertical value generates an error when starting vim:

E474: Invalid argument: diffopt+=vertical

See: thoughtbot/dotfiles#655 (comment)

Potential fix is to update the affected section in vimrc:

if &diff
    set diffopt+=vertical
endif
@djagellon djagellon self-assigned this Oct 5, 2021
@djagellon
Copy link
Author

djagellon commented Oct 5, 2021

@Endtry Trying to push a fix for this repo but I don't think I have write access.

@DropsOfSerenity
Copy link
Contributor

@djagellon If you can make a pull request for this I can get it merged in.

@djagellon
Copy link
Author

Thanks @DropsOfSerenity I tried to, but I don't seem to have write access to the repo.

@DropsOfSerenity
Copy link
Contributor

@djagellon You'll want to fork the repository, then make a pull request from your fork :)

@djagellon
Copy link
Author

ah. Thank you, I thought pulling and creating a new branch would be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants