Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Extract shared behaviour of test disco listeners #3288

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] Extract shared behaviour of test disco listeners #3288

wants to merge 1 commit into from
+117 −86

Conversation

alexcrocha
Copy link
Contributor

Motivation

WIP

Implementation

Automated Tests

Manual Tests

@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 10, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@alexcrocha alexcrocha force-pushed the ar/refactor-test-disco-listeners branch from a28112a to 3474d77 Compare March 11, 2025 00:35
@andyw8
Copy link
Contributor

andyw8 commented Mar 11, 2025

We're seeing some RuboCop failures because the UseRegisterWithHandlerMethod cop doesn't understand inheritance. https://github.com/Shopify/ruby-lsp/compare/dynamic-handler-registration would solve that if we go ahead.

andyw8
andyw8 reviewed Mar 11, 2025
View reviewed changes
lib/ruby_lsp/listeners/test_style.rb

@nesting << name
#: (Prism::ClassNode node) -> void
def on_class_node_leave(node)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need these methods that do nothing but call super.

andyw8
andyw8 reviewed Mar 11, 2025
View reviewed changes
lib/ruby_lsp/listeners/discover_tests.rb
extend T::Helpers
abstract!

include Requests::Support::Common
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since its now in the parent, we can remove this include from the child classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyw8 andyw8 andyw8 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrocha @andyw8