Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ERB syntax highlighting in Heredoc sections #3292

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

domingo2000
Copy link
Contributor

Motivation

Closes #2863

Implementation

This is a follow up of this PR #2903

Added .erb grammar to the vscode grammar extension.

Automated Tests

Added test for erb grammar in the grammars.test.ts

Manual Tests

I run the extension locally. The grammar is taking the ERB block in the heredoc. But for some reason, reusing the text.html.erb grammar of the RubyLSP extension gives different syntax highlighting than in a example.erb file.

example.rb
image
example.erb
image

@domingo2000 domingo2000 requested a review from a team as a code owner March 11, 2025 17:28
Copy link

graphite-app bot commented Mar 11, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlight for ERB in heredoc
1 participant