-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging type error #1013
Comments
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
We are closing this issue because it has been inactive for a few months. If you still encounter this issue with the latest stable version, please reopen using the issue template. You can also contribute directly by submitting a pull request– see the CONTRIBUTING.md file for guidelines Thank you! |
This error also occurs with GCP's Stackdriver gem, which replaces the Logger with a Google::Cloud::Logging::Logger. |
I'm also getting this issue with Stackdriver - how did you end up fixing it? |
Issue summary
I'm trying to change the global logger to
SemanticLogger::Logger
but facing a Sorbet type error.Expected behavior
I'd expect that ShopifyAPI would allow using any logger
Actual behavior
Sorbet type check error
Steps to reproduce the problem
gem "rails_semantic_logger"
to gem filebundle install
ShopifyAPI::Context.setup( logger: Rails.logger )
rails s
Logs
Specifications
shopify_api
version: 11.1.02022-07
):The text was updated successfully, but these errors were encountered: