Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Run storybook-test:ci as part of our design approval process + Show previews on PRs #9335

Open
ntindle opened this issue Jan 26, 2025 — with Linear · 0 comments

Comments

Copy link
Member

ntindle commented Jan 26, 2025

We added Storybook to our system to help design stability and progress but currently aren't working on

  • Upkeeping storybook
  • Ensuring its tests pass
  • Getting design write-off

In order to do these things, adding Storybook to the CI would be wise.

TODO:

  • Fix the storybook tests to be
    • Running
    • Functional
    • Meaningful
  • Fix the components
    • Not require external classes for styling
    • Match Pixel for pixel the designs in storybook renderer
  • Add the following to platform-frontend-ci.yml
    ```yml
    - name: Run Storybook
    run: |
    yarn storybook-test:ci
    ```
  • Add @OliviaGrace as a required approver for anthing in the following folders
    • autogpt_platform/frontend/src/components/ui
    • autogpt_platform/frontend/src/components/agptui
@ntindle ntindle changed the title Run storybook-test:ci in ci Fix and Run storybook-test:ci as part of our design approval process Jan 26, 2025
@ntindle ntindle changed the title Fix and Run storybook-test:ci as part of our design approval process Fix and Run storybook-test:ci as part of our design approval process + Show previews Jan 28, 2025
@ntindle ntindle changed the title Fix and Run storybook-test:ci as part of our design approval process + Show previews Fix and Run storybook-test:ci as part of our design approval process + Show previews on PRs Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant