Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alt-X saves all files and exits without confirmation #30

Open
garfieldnate opened this issue Aug 9, 2024 · 1 comment
Open

alt-X saves all files and exits without confirmation #30

garfieldnate opened this issue Aug 9, 2024 · 1 comment

Comments

@garfieldnate
Copy link
Contributor

This seems rather dangerous to me. I tried to come up with a fix in the confirm_before_exit branch, but hit an issue where the alt-X event was not consumed, leading to a "≈" input before the confirm/save/close action could run.
garfieldnate added a commit that referenced this issue Aug 12, 2024
@garfieldnate
Confirm with user when x-ing out of app
1fc0d2f 
See #30, for which this is a related partial fix.

Lots of whitespace changes added by IDE as well. Sorry. I'm tired of avoiding
committing them.
garfieldnate added a commit that referenced this issue Aug 13, 2024
@garfieldnate
Confirm on exit
0d1a1d5 
This does cause a ≈ to be input on Mac, but it's much better than not confirming
before exit. See #30.
@garfieldnate
Copy link
Contributor Author

So the actual status on this ticket now is that alt-x will confirm before closing the app, but on Mac it always inputs a ≈ in the current file before saving, which is pretty annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garfieldnate