You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we check if the assert commands are used in tests.
I have detected some places (e.g., repo Tface) where the assert expressions are used just to check if the inputs to the script are correct. This is not a good practice, but we should not assume that any function with assert is a test. Alternatives:
Check if any of the imports include the test frameworks.
Check if the assert functions are the last call in the target function. This way, we'll know it is a test instead of asserting a in input condition.
The text was updated successfully, but these errors were encountered:
Right now we check if the
assert
commands are used in tests.I have detected some places (e.g., repo
Tface
) where theassert
expressions are used just to check if the inputs to the script are correct. This is not a good practice, but we should not assume that any function withassert
is a test. Alternatives:The text was updated successfully, but these errors were encountered: