Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncleared function name reference: Function section and call information #350

Open
OEG-Clark opened this issue Jun 20, 2022 · 4 comments
Open
Assignees
Labels
bug Something isn't working
Milestone

Comments

@OEG-Clark
Copy link
Contributor

With the review of 12,000 repos, I have found the reference for function names ambiguous. For example, in the image given below, we could see there are two select_builder, but the reference name is different.
image

It would be beneficial if for each repo, we could have a functions list or index. Or if inspect4py could unify the naming scheme for each function. For example, we could define the inspect4py result as folder.file.(class).function_name, which would keep the uniqueness and cohesion of each function/class name.

@dgarijo dgarijo added the bug Something isn't working label Jun 20, 2022
@dgarijo
Copy link
Collaborator

dgarijo commented Jun 20, 2022

I think the problem here is that select_builder. is very strange. Please post here the original source code and the repository name, so we can identify it

@dgarijo dgarijo added this to the v0.0.2 milestone Jun 20, 2022
@dgarijo dgarijo self-assigned this Jun 20, 2022
@OEG-Clark
Copy link
Contributor Author

@OEG-Clark
Copy link
Contributor Author

Another issue that could occur is given by the following.

The image below shows a piece of call information from a function named ds_item. So the direction for this function is pipetools/ds_builder.ds_tiem. And you could see the reference for a function is ds_builder.DSBuilder which is file.function_name, however, there is a call from the same folder which is pipetools, and it is named pipetools.main.StringFormatter which is folder.file.function.

The reference is https://github.com/0101/pipetools/blob/master/pipetools/ds_builder.py#:~:text=return%20builder-,def%20ds_item(definition%2C%20data)%3A,return%20definition,-%C2%A9%202022%20GitHub%2C%20Inc.

image

@dgarijo
Copy link
Collaborator

dgarijo commented Jun 21, 2022

So the problem is that ds_builder.DSBuilder should have been pipetools.ds_builder.DSBuilder.

Basically, the package structure should be dded in the local files too.

@dgarijo dgarijo modified the milestones: v0.0.2, v0.0.3 Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants