Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to modifier #25

Open
cah-brian-gantzler opened this issue Sep 3, 2020 · 2 comments
Open

Convert to modifier #25

cah-brian-gantzler opened this issue Sep 3, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cah-brian-gantzler
Copy link

Just found this, interesting. Having just re-written ember-sortable as a modifier, was wondering if you were open to this being a modifier as well instead of as a component.

Given that you need access to the DOM element to make things happen, this is almost a guarantee should be a modifier.

@lvegerano
Copy link
Collaborator

I'll will explore that. Thanks for the suggestion.

@lvegerano lvegerano self-assigned this Nov 7, 2020
@lvegerano lvegerano added the enhancement New feature or request label Nov 7, 2020
@cah-brian-gantzler
Copy link
Author

I had recently rewritten https://github.com/adopted-ember-addons/ember-sortable to be a modifier. You can look at that repo for examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants