Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring Items are not selected after paste #21

Open
lemomar opened this issue Mar 30, 2023 · 4 comments
Open

Ring Items are not selected after paste #21

lemomar opened this issue Mar 30, 2023 · 4 comments
Assignees

Comments

@lemomar
Copy link

lemomar commented Mar 30, 2023

Hi there,

I've been using your extension with the default settings, and I'm encountering an issue where pasting ring items with Cmd+Shift+V works, but it does not select them. So instead of cycling through ring items, it just pastes them in a chain.

At first I thought it was due to my user settings, but the problem remains even after removing them all. Is this a common issue?

And lastly, thanks for the amazing extension.

@lemomar lemomar changed the title Ring Item is not selected after paste Ring Items are not selected after paste Mar 30, 2023
@lemomar
Copy link
Author

lemomar commented Mar 30, 2023

More info: Tried this on a fresh installation of VsCode, and I can reproduce the issue.

It also applies to the Select and Paste Ring Item command, even with clipring.selectTextAfterPasteFromMenu set to true.

@SrTobi
Copy link
Owner

SrTobi commented Mar 31, 2023

Thanks for reporting. I can reproduce the error. I'll have a look in the next few days.

@SrTobi SrTobi self-assigned this Mar 31, 2023
@gillez
Copy link

gillez commented May 12, 2023

Hi, I am also seeing this issue. Have you been able to fix this yet?
Thanks, Giles

@SrTobi
Copy link
Owner

SrTobi commented May 14, 2023

Hmm seems that there was a change in how the vscode api handles empty selections when replacing text

eb.replace(sel, ring!.getCurrent());

It works when some text is selected.
I have created an issue in vscode, but I guess I'll come up with a workaround until it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants