Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications via Shoutrrr #2994

Closed
kytta opened this issue Jun 6, 2024 · 3 comments · Fixed by #3215
Closed

Notifications via Shoutrrr #2994

kytta opened this issue Jun 6, 2024 · 3 comments · Fixed by #3215

Comments

@kytta
Copy link
Contributor

kytta commented Jun 6, 2024

Is your feature request related to a problem? Please describe.
Currently, there is a limited number of notification types. Adding a new one is simple, but each notification type would require their own configuration parameters. Sometimes it's a token, sometimes it's a URL, sometimes it's both.

Describe the solution you'd like
We could consider using Shoutrrr, which is a Go library for notifications. Unlike the current solution, it uses a single URL for a notification type, and this URL encodes all information needed, be it tokens or other metadata. It supports all current notification types natively except for Bonfire, but since it also has webhook support, Bonfire is also easy to implement.

Describe alternatives you've considered
An obvious alternative would be to implement all notification types from scratch

Additional context
N/A

@tlimoncelli
Copy link
Contributor

Hi there!

Shoutrrr sounds great! Would you be interested in sending a PR? I'd be glad to assist.

Tom

@kytta
Copy link
Contributor Author

kytta commented Jun 6, 2024

Would you be interested in sending a PR? I'd be glad to assist.

Yes! I don't have much experience with Go, but one always has to start somewhere :)

hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Nov 27, 2024
hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Nov 27, 2024
@hmoffatt
Copy link
Contributor

Hey @kytta want to try out this on my PR?

hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Dec 3, 2024
hmoffatt added a commit to hmoffatt/dnscontrol that referenced this issue Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants