Disable PDA pause option (#2286)

Author: tornac1234

Nitrox.Test/Patcher/Patches/PatchesTranspilerTest.cs

@@ -68,6 +68,7 @@ public class PatchesTranspilerTest
         [typeof(SpawnOnKill_OnKill_Patch), 3],
         [typeof(SubConsoleCommand_OnConsoleCommand_sub_Patch), 0],
         [typeof(SubRoot_OnPlayerEntered_Patch), 5],
+        [typeof(uGUI_OptionsPanel_AddAccessibilityTab_Patch), -10],
         [typeof(uGUI_PDA_Initialize_Patch), 2],
         [typeof(uGUI_PDA_SetTabs_Patch), 3],
         [typeof(uGUI_Pings_IsVisibleNow_Patch), 0],

NitroxClient/MonoBehaviours/Gui/Modals/Modal.cs

@@ -92,7 +92,7 @@ public void Hide()
         CurrentModal = null;
         if (FreezeGame)
         {
-            FreezeTime.End(FreezeTime.Id.IngameMenu);
+            FreezeTime.End(FreezeTime.Id.Quit);
         }
         if (IsAvoidable)
         {

NitroxClient/MonoBehaviours/NitroxBootstrapper.cs

@@ -25,6 +25,8 @@ private void Awake()
         // This is very important, see Application_runInBackground_Patch.cs
         Application.runInBackground = true;
         Log.Info($"Unity run in background set to \"{Application.runInBackground}\"");
+        // Also very important for similar reasons
+        MiscSettings.pdaPause = false;
     }
 
 #if DEBUG

NitroxPatcher/Patches/Dynamic/FreezeTime_Begin_Patch.cs NitroxPatcher/Patches/Dynamic/FreezeTime_Set_Patch.cs

@@ -6,15 +6,15 @@
 namespace NitroxPatcher.Patches.Dynamic;
 
 /// <summary>
-/// Because we're in multiplayer mode, we generally don't want the game to freeze
+/// Because we're in multiplayer mode, we generally don't want the game to freeze.
+/// Thus we prevent any FreezeTime that is not for quit screen or (initial sync) wait screen.
 /// </summary>
-public sealed partial class FreezeTime_Begin_Patch : NitroxPatch, IDynamicPatch
+public sealed partial class FreezeTime_Set_Patch : NitroxPatch, IDynamicPatch
 {
-    private static readonly MethodInfo TARGET_METHOD = Reflect.Method(() => FreezeTime.Begin(default(FreezeTime.Id)));
+    private static readonly MethodInfo TARGET_METHOD = Reflect.Method(() => FreezeTime.Set(default, default));
 
-    private static readonly HashSet<FreezeTime.Id> allowedFreezeIds = new() { FreezeTime.Id.Quit, FreezeTime.Id.WaitScreen };
+    private static readonly HashSet<FreezeTime.Id> allowedFreezeIds = [FreezeTime.Id.Quit, FreezeTime.Id.WaitScreen];
 
-    // We don't want to prevent from freezing the game if the opened modal wants to freeze the game
     public static bool Prefix(FreezeTime.Id id)
     {
         return allowedFreezeIds.Contains(id);

NitroxPatcher/Patches/Persistent/uGUI_OptionsPanel_AddAccessibilityTab_Patch.cs

@@ -0,0 +1,30 @@
+using System.Collections.Generic;
+using System.Reflection;
+using System.Reflection.Emit;
+using HarmonyLib;
+using NitroxModel.Helper;
+
+namespace NitroxPatcher.Patches.Persistent;
+
+/// <summary>
+/// Remove the option for PDA pause
+/// </summary>
+public sealed partial class uGUI_OptionsPanel_AddAccessibilityTab_Patch : NitroxPatch, IPersistentPatch
+{
+    private static readonly MethodInfo TARGET_METHOD = Reflect.Method((uGUI_OptionsPanel t) => t.AddAccessibilityTab());
+
+    /// <summary>
+    /// Simply removes following line
+    /// AddToggleOption(num, "PDAPause" ...
+    /// </summary>
+    public static IEnumerable<CodeInstruction> Transpiler(IEnumerable<CodeInstruction> instructions)
+    {
+        return new CodeMatcher(instructions).MatchStartForward([
+                                                new(OpCodes.Ldarg_0),
+                                                new(OpCodes.Ldloc_0),
+                                                new(OpCodes.Ldstr, "PDAPause")
+                                            ])
+                                            .RemoveInstructions(10)
+                                            .InstructionEnumeration();
+    }
+}