Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review existing implementation, aggregate notes, make a plan for forward progress #47

Open
2 of 3 tasks
KendallWeihe opened this issue Apr 29, 2024 · 2 comments
Open
2 of 3 tasks
Assignees

Comments

@KendallWeihe
Copy link
Contributor

KendallWeihe commented Apr 29, 2024

This repo hasn't been touched in many months so this ticket is intended to establish existing contributions, critique existing solutions, and plan forward progress

  • Review existing backlog
  • Review existing source code & aggregate personal commentary
  • Create issues for work going forward
@KendallWeihe KendallWeihe self-assigned this Apr 29, 2024
@KendallWeihe
Copy link
Contributor Author

KendallWeihe commented Apr 29, 2024

Notes from my first pass through:

  • setting types as typeid's will make extra work for bindings
  • generics are extra work for bindings
  • Resources
    • signature is optional but shouldn’t be
    • metadata
      • updated_at should be optional
      • missing protocol
    • missing signing functionality (existing issue)
    • missing digest (existing issue)
    • missing verify functionality (existing issue)
    • unclear what required_payment_details_schema is for?
    • missing json schema validation
    • missing balance
    • offering
      • payin/payout rework
      • from_json_string() (AKA parse())
  • Messages
    • “valid next” feature
    • missing externalId
    • missing protocol
    • signature is optional
    • missing signing (existing issue)
    • missing digest (existing issue)
    • missing verifying (existing issue)
    • missing private
    • missing json schema validation
    • missing rfq altogether (existing issue)
    • quote
      • QuoteDetails rename fields and missing instructions (move from QuoteData)
      • missing parse()
    • order
      • missing parse()
    • order status
      • missing parse()
    • close
      • missing optional success boolean
      • missing parse()
  • http-server we can probably hold off for the time being
  • http-client we should implement

@KendallWeihe
Copy link
Contributor Author

My starting point on this work is here, mostly with the intent of gaining initial footing and building a bit of momentum #56

I expect to take an iterative approach here, so a bit of coding and then a bit of project management, rinse and repeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant