Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API leak on com.danubetech:verifiable-credentials-java #228

Closed
ALRubinger opened this issue Feb 12, 2024 · 2 comments
Closed

API leak on com.danubetech:verifiable-credentials-java #228

ALRubinger opened this issue Feb 12, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ALRubinger
Copy link
Contributor

ALRubinger commented Feb 12, 2024 •
edited
Loading

Submodule credentials in web5-kt is exporting an api dependency:

  • api(libs.comDanubetechVerifiableCredentials) > com.danubetech:verifiable-credentials-java

This means consumers are expected to use this dep directly. Encapsulate necessary operations in the web5-kt API such that we're not exposing the com.danubetech APIs and asking users to rely on those. Our use internally should be an impl detail. Then move this to an implementation dependency.
@ALRubinger ALRubinger added enhancement New feature or request good first issue Good for newcomers labels Feb 12, 2024
@frankhinek
Copy link
Contributor

Should be resolved by #188

@jiyoontbd jiyoontbd mentioned this issue Feb 16, 2024
Open
@jiyoontbd
Copy link
Contributor

closing as duplicate of #188

@jiyoontbd jiyoontbd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frankhinek @ALRubinger @jiyoontbd