Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab gibbs handles more derivative combinations #61

Open
efiring opened this issue Apr 17, 2023 · 3 comments
Open

Matlab gibbs handles more derivative combinations #61

efiring opened this issue Apr 17, 2023 · 3 comments

Comments

@efiring
Copy link
Member

efiring commented Apr 17, 2023

The current Matlab code handles the following (ns, nt, np) argument sets to the gibbs function, that are not included in GSW-C:
030, 021, 111, 201, 120, 210, 102, 012.
Evidently these are not use in any of the other functions included in GSW-C.
Is there any point in adding them?

@ocefpaf
Copy link
Member

ocefpaf commented Apr 17, 2023

Is there any point in adding them?

Asking here will only reach a subset of the users. IMO, no. But I don't have any application for those. Is there a TEOS-10 mailing list that we could ask this? Or maybe @PaulMBarker could give us some insight on what Matlab users are doing with those?

@efiring
Copy link
Member Author

efiring commented Apr 17, 2023

The terms that are included in the Matlab but not the Fortran or C are the 3rd order derivatives. In the Matlab they date back to at least March, 2017. I'm sure @PaulMBarker will be able to provide the background as to why they are there, and guidance as to whether we should add them.

@PaulMBarker
Copy link
Member

Some of programmes are codes I wrote for myself, but have shared them through the toolbox. Also some took a huge amount of work and it seemed a shame to ignore or scrap them.
I would suggest it would be more beneficial to the community to focus om adding more programmes that use or are based on the 76 term polynomial.
But having said that, I am happy to see any programme translated from Matlab to C, as they may will be useful to some oceanographers and lead to advancements in the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants