Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson build file? #72

Open
peter-urban opened this issue Sep 18, 2024 · 3 comments
Open

Meson build file? #72

peter-urban opened this issue Sep 18, 2024 · 3 comments

Comments

@peter-urban
Copy link
Contributor

I created a meson.build file (with tests) to more easily integrate this project with my existing projects.
I was wondering if you want to add this to the main project? (It can live next to the Makefile)
If so, I can work on a clean PR.

If not: feel free to reject this issue. It is no problem maintain this as separate fork.

@ocefpaf
Copy link
Member

ocefpaf commented Sep 18, 2024

I'll defer to Eric but, IMO, I welcomed a meson build. We might as well use it in the future to build the Python extension too. My only concern is with the increased complexity. I would remove the Makefile in the future if all we need is the meson.build.

to more easily integrate this project with my existing projects.

Just out of curiosity, what are you building?

@peter-urban
Copy link
Contributor Author

Just out of curiosity, what are you building?

themachinethatgoesping It's is a multibeam and singlebeam python processing library (written in c++). GSW-C is to be used for absorption computation.

We might as well use it in the future to build the Python extension too.

I am happy to contribute if you want to move in this direction . I use meson with meson-python as a build backend for my python extensions. Though I don't have experience with ufunc etc. Anyways, that's an issue for GSW-Python once this issue is discussed ;-)

@efiring
Copy link
Member

efiring commented Sep 18, 2024

I would welcome the meson build for this project, as well as the possibility of your participation in additional projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants