Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure since 0.1.2 (gsw_sstar_from_sp) #31

Closed
Alexander-Barth opened this issue Feb 2, 2024 · 2 comments
Closed

Test failure since 0.1.2 (gsw_sstar_from_sp) #31

Alexander-Barth opened this issue Feb 2, 2024 · 2 comments

Comments

@Alexander-Barth
Copy link
Member

Alexander-Barth commented Feb 2, 2024

The following test fails since 0.1.2.
Version 0.1.1 is still ok.

The reference data on which this test is based remained the same
https://github.com/TEOS-10/GSW-C/blob/master/gsw_data_v3_0.nc

Absolute Salinity, Preformed Salinity and Conservative Temperature: Test Failed at /home/runner/work/GibbsSeaWater.jl/GibbsSeaWater.jl/test/runtests.jl:20
  Expression: ≈(gsw_sstar_from_sp.(sp, p, lon, lat)[mask], sstar_from_sp[mask], atol = sstar_from_sp_ca)
   Evaluated: [34.50725698645741, 34.50678124228232, 34.50160361305484, 34.504185680748904, 34.530387640325195, 34.53722096762431, 34.73577748513168, 34.988706391643824, 35.11985942587779, 35.11843623487062  …  34.86204201714164, 34.86401676373187, 6.669904340924572, 6.773781441891427, 6.912953064476571, 7.137520672097142, 7.3661052164125715, 7.586220919642284, 9.167624152367999, 10.389468455026284] ≈ 
Union{Missing, Float64}[34.50725735555258, 34.50678186154884, 34.50160415391436, 34.504186106832115, 34.530388583505314, 34.53722448713483, 34.735783282747455, 34.988715833137896, 35.119874921741776, 35.11845699407066  …  34.862050046564775, 34.86401585477976, 6.669904340924572, 6.773781441891427, 6.912953064476571, 7.137520672097142, 7.3661052164125715, 7.586220919642284, 9.167624152367999, 10.389468455026284] (atol=1.3000089893466793e-10)

Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.0/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:672 [inlined]
 [2] macro expansion
   @ ~/work/GibbsSeaWater.jl/GibbsSeaWater.jl/test/runtests.jl:20 [inlined]
 [3] macro expansion
   @ /opt/hostedtoolcache/julia/1.10.0/x64/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
 [4] top-level scope
   @ ~/work/GibbsSeaWater.jl/GibbsSeaWater.jl/test/runtests.jl:48
Test Summary:                                                      | Pass  Fail  Total  Time
Absolute Salinity, Preformed Salinity and Conservative Temperature |    1     2      3  1.9s
ERROR: LoadError: Some tests did not pass: 1 passed, 2 failed, 0 errored, 0 broken.
in expression starting at /home/runner/work/GibbsSeaWater.jl/GibbsSeaWater.jl/test/runtests.jl:47
ERROR: LoadError: Package GibbsSeaWater errored during testing
@Alexander-Barth Alexander-Barth changed the title Test failure since 0.1.2 Test failure since 0.1.2 (gsw_sstar_from_sp) Feb 2, 2024
@Alexander-Barth
Copy link
Member Author

Alexander-Barth commented Feb 3, 2024

The C library GSW-C passes its tests using the reference values in gsw_check_data.h:

$ ./gsw_check 
# no error

But if gsw_check_data.h is recreated from the netCDF file gsw_data_v3_0.nc using the python script make_check_data.py, then the tests fails:

$ ./gsw_check 
============================================================================
 Gibbs SeaWater (GSW) Oceanographic Toolbox of TEOS-10 version 3.05 (C)
============================================================================

 These are the check values for the subset of functions that have been 
 converted into C from the Gibbs SeaWater (GSW) Oceanographic Toolbox 
 of TEOS-10 (version 3.05).

----------------------------------------------------------------------------
Practical Salinity, PSS-78

c_from_sp........................................................ passed ( 92)
sp_from_c........................................................ passed ( 92)
sp_from_sk....................................................... passed ( 98)
sp_salinometer................................................... passed ( 98)

----------------------------------------------------------------------------
Absolute Salinity, Preformed Salinity and Conservative Temperature

sa_from_sp.................................................... << failed >>

  Max difference = 0.00018680994066500034, limit = 1.3000800436202553e-10
  Max diff (rel) = 0.0005367930846170673, limit = 3.7357432606623484e-10
  Max at index 60, calcval= 34.801107916333379, refval= 34.800921106392714
sstar_from_sp................................................. << failed >>

  Max difference = 6.5383479231684305e-05, limit = 1.3000089893466793e-10
  Max diff (rel) = 0.00018791181085410112, limit = 3.7362197023673349e-10
  Max at index 60, calcval= 34.794768319512116, refval= 34.794833702991347
ct_from_t........................................................ passed ( 98)
sa_from_sp_lon_wrapped_high (sa_from_sp)...................... << failed >>

  Max difference = 0.00018680994066500034, limit = 1.3000800436202553e-10
  Max diff (rel) = 0.0005367930846170673, limit = 3.7357432606623484e-10
  Max at index 60, calcval= 34.801107916333379, refval= 34.800921106392714
sa_from_sp_lon_wrapped_low (sa_from_sp)....................... << failed >>

  Max difference = 0.00018680994066500034, limit = 1.3000800436202553e-10
  Max diff (rel) = 0.0005367930846170673, limit = 3.7357432606623484e-10
  Max at index 60, calcval= 34.801107916333379, refval= 34.800921106392714

----------------------------------------------------------------------------
Other conversions between Temperatures, Salinities, Entropy, Pressure and Height

deltasa_from_sp............................................... << failed >>

  Max difference = 0.00018680994067921119, limit = 6.9633188104489818e-13
  Max diff (rel) = 3.9780671709468822, limit = 1.4828199109731099e-08
  Max at index 60, calcval= 0.0046959976453777585, refval= 0.0045091877046985473
sr_from_sp....................................................... passed ( 98)
sp_from_sr....................................................... passed ( 98)
sp_from_sa.................................................... << failed >>

  Max difference = 0.00018590809651897189, limit = 1.2971135276984569e-10
  Max diff (rel) = 0.00053679596608509003, limit = 3.7453199847693376e-10
  Max at index 60, calcval= 34.632916091903482, refval= 34.633102000000001
ssp_from_sa_lon_wrapped_high (sp_from_sa)..................... << failed >>

  Max difference = 0.00018590809651897189, limit = 1.2971135276984569e-10
  Max diff (rel) = 0.00053679596608509003, limit = 3.7453199847693376e-10
  Max at index 60, calcval= 34.632916091903482, refval= 34.633102000000001
sa_from_sp_lon_wrapped_low (sp_from_sa)....................... << failed >>

  Max difference = 0.00018590809651897189, limit = 1.2971135276984569e-10
  Max diff (rel) = 0.00053679596608509003, limit = 3.7453199847693376e-10
  Max at index 60, calcval= 34.632916091903482, refval= 34.633102000000001
sstar_from_sa................................................. << failed >>

  Max difference = 0.00025215938937606097, limit = 1.3000089893466793e-10
  Max diff (rel) = 0.00072470878564834468, limit = 3.7362397582439805e-10
  Max at index 60, calcval= 34.794581543601979, refval= 34.794833702991355
sa_from_sstar.................................................... passed ( 98)
sp_from_sstar................................................. << failed >>

  Max difference = 0.00018590809650476103, limit = 1.2971224094826539e-10
  Max diff (rel) = 0.0005367959660440571, limit = 3.7453456302684721e-10
  Max at index 60, calcval= 34.632916091903489, refval= 34.633101999999994
pt_from_ct....................................................... passed ( 98)
t_from_ct........................................................ passed ( 98)
ct_from_pt....................................................... passed ( 98)
pt0_from_t....................................................... passed ( 98)
pt_from_t........................................................ passed ( 98)
z_from_p......................................................... passed ( 98)
p_from_z......................................................... passed ( 98)
entropy_from_pt.................................................. passed ( 98)
pt_from_entropy.................................................. passed ( 98)
ct_from_entropy.................................................. passed ( 98)
entropy_from_ct.................................................. passed ( 98)
entropy_from_t................................................... passed ( 98)
adiabatic_lapse_rate_from_ct..................................... passed ( 98)

----------------------------------------------------------------------------
Specific Volume, Density and Enthalpy

specvol.......................................................... passed ( 98)
alpha............................................................ passed ( 98)
beta............................................................. passed ( 98)
alpha_on_beta.................................................... passed ( 98)
specvol_alpha_beta (v_vab)....................................... passed ( 98)
specvol_alpha_beta (alpha_vab)................................... passed ( 98)
specvol_alpha_beta (beta_vab).................................... passed ( 98)
specvol_first_derivatives (v_sa)................................. passed ( 98)
specvol_first_derivatives (v_ct)................................. passed ( 98)
specvol_first_derivatives (v_p).................................. passed ( 98)
specvol_second_derivatives (v_sa_sa)............................. passed ( 98)
specvol_second_derivatives (v_sa_ct)............................. passed ( 98)
specvol_second_derivatives (v_ct_ct)............................. passed ( 98)
specvol_second_derivatives (v_sa_p)........................... << failed >>

  Max difference = 2.9382892612553006e-16, limit = 1.303553202832461e-26
  Max diff (rel) = 20.896467726513102, limit = 9.2705840068121602e-10
  Max at index 23, calcval= 1.4061176748677225e-15, refval= 1.6999466009932526e-15
specvol_second_derivatives (v_ct_p).............................. passed ( 98)
specvol_first_derivatives_wrt_enthalpy (v_sa_wrt_h).............. passed ( 98)
specvol_first_derivatives_wrt_enthalpy (v_h)..................... passed ( 98)
specvol_second_derivatives_wrt_enthalpy (v_sa_sa_wrt_h)....... << failed >>

  Max difference = 5.3725931308895906e-12, limit = 1.9904240284710367e-20
  Max diff (rel) = 0.73127530324228285, limit = 2.7092093139014135e-09
  Max at index 44, calcval= 7.346881683367293e-10, refval= 7.400607614676189e-10
specvol_second_derivatives_wrt_enthalpy (v_sa_h)................. passed ( 98)
specvol_second_derivatives_wrt_enthalpy (v_h_h).................. passed ( 98)
specvol_anom_standard............................................ passed ( 98)
rho.............................................................. passed ( 98)
rho_alpha_beta (rho_rab)......................................... passed ( 98)
rho_alpha_beta (alpha_rab)....................................... passed ( 98)
rho_alpha_beta (beta_rab)........................................ passed ( 98)
rho_first_derivatives (rho_sa)................................... passed ( 98)
rho_first_derivatives (rho_ct)................................... passed ( 98)
rho_first_derivatives (rho_p).................................... passed ( 98)
rho_second_derivatives (rho_sa_sa)............................... passed ( 98)
rho_second_derivatives (rho_sa_ct)............................... passed ( 98)
rho_second_derivatives (rho_ct_ct)............................... passed ( 98)
rho_second_derivatives (rho_sa_p)............................. << failed >>

  Max difference = 3.1401670671459799e-10, limit = 1.1000468171189577e-20
  Max diff (rel) = 38.484348116858271, limit = 1.3481634495748262e-09
  Max at index 25, calcval= -8.159595318103916e-10, refval= -1.1299762385249896e-09
rho_second_derivatives (rho_ct_p)................................ passed ( 98)
rho_first_derivatives_wrt_enthalpy (rho_sa_wrt_h)................ passed ( 98)
rho_first_derivatives_wrt_enthalpy (rho_h)....................... passed ( 98)
rho_second_derivatives_wrt_enthalpy (rho_sa_sa_wrt_h)......... << failed >>

  Max difference = 5.9786298124043938e-06, limit = 1.9459694272638828e-14
  Max diff (rel) = 2.4512223964570006, limit = 7.9784231380793666e-09
  Max at index 44, calcval= 0.00024390401381147266, refval= 0.00023792538399906827
rho_second_derivatives_wrt_enthalpy (rho_sa_h)................... passed ( 98)
rho_second_derivatives_wrt_enthalpy (rho_h_h).................... passed ( 98)
sigma0........................................................... passed ( 98)
sigma1........................................................... passed ( 98)
sigma2........................................................... passed ( 98)
sigma3........................................................... passed ( 98)
sigma4........................................................... passed ( 98)
sound_speed...................................................... passed ( 98)
kappa............................................................ passed ( 98)
cabbeling........................................................ passed ( 98)
thermobaric................................................... << failed >>

  Max difference = 1.0995945804096109e-13, limit = 5.1742409137179331e-23
  Max diff (rel) = 7.621983283161863, limit = 3.5865925905818098e-09
  Max at index 0, calcval= 1.4426620205777478e-12, refval= 1.5526214786187089e-12
sa_from_rho...................................................... passed ( 98)
ct_from_rho...................................................... passed ( 93)
ct_maxdensity.................................................... passed ( 98)
internal_energy.................................................. passed ( 98)
enthalpy......................................................... passed ( 98)
enthalpy_diff.................................................... passed ( 98)
ct_from_enthalpy................................................. passed ( 98)
dynamic_enthalpy................................................. passed ( 98)
enthalpy_first_derivatives (h_sa)................................ passed ( 98)
enthalpy_first_derivatives (h_ct)................................ passed ( 98)
enthalpy_second_derivatives (h_sa_sa)............................ passed ( 98)
enthalpy_second_derivatives (h_sa_ct)............................ passed ( 98)
enthalpy_second_derivatives (h_ct_ct)............................ passed ( 98)

----------------------------------------------------------------------------
Derivatives of entropy, CT and pt

ct_first_derivatives (ct_sa)..................................... passed ( 98)
ct_first_derivatives (ct_pt)..................................... passed ( 98)
ct_second_derivatives (ct_sa_sa)................................. passed ( 98)
ct_second_derivatives (ct_sa_pt)................................. passed ( 98)
ct_second_derivatives (ct_pt_pt)................................. passed ( 98)
entropy_first_derivatives (eta_sa)............................... passed ( 98)
entropy_first_derivatives (eta_ct)............................... passed ( 98)
entropy_second_derivatives (eta_sa_sa)........................... passed ( 98)
entropy_second_derivatives (eta_sa_ct)........................... passed ( 98)
entropy_second_derivatives (eta_ct_ct)........................... passed ( 98)
pt_first_derivatives (pt_sa)..................................... passed ( 98)
pt_first_derivatives (pt_ct)..................................... passed ( 98)
pt_second_derivatives (pt_sa_sa)................................. passed ( 98)
pt_second_derivatives (pt_sa_ct)................................. passed ( 98)
pt_second_derivatives (pt_ct_ct)................................. passed ( 98)

----------------------------------------------------------------------------
Freezing temperatures

ct_freezing...................................................... passed ( 98)
ct_freezing_poly................................................. passed ( 98)
t_freezing....................................................... passed ( 98)
t_freezing_poly.................................................. passed ( 98)
pot_enthalpy_ice_freezing........................................ passed ( 98)
pot_enthalpy_ice_freezing_poly................................... passed ( 98)
sa_freezing_from_ct.............................................. passed ( 98)
sa_freezing_from_ct_poly......................................... passed ( 98)
sa_freezing_from_t............................................... passed ( 98)
sa_freezing_from_t_poly.......................................... passed ( 98)
ct_freezing_first_derivatives (ctfreezing_sa).................... passed ( 98)
ct_freezing_first_derivatives (ctfreezing_p)..................... passed ( 98)
ct_freezing_first_derivatives_poly (ctfreezing_sa_poly).......... passed ( 98)
ct_freezing_first_derivatives_poly (ctfreezing_p_poly)........... passed ( 98)
t_freezing_first_derivatives (tfreezing_sa)...................... passed ( 98)
t_freezing_first_derivatives (tfreezing_p)....................... passed ( 98)
t_freezing_first_derivatives_poly (tfreezing_sa_poly)............ passed ( 98)
t_freezing_first_derivatives_poly (tfreezing_p_poly)............. passed ( 98)
pot_enthalpy_ice_freezing_first_derivatives (..ce_freezing_sa)... passed ( 98)
pot_enthalpy_ice_freezing_first_derivatives (..ice_freezing_p)... passed ( 98)
pot_enthalpy_ice_freezing_first_derivatives_poly (..g_sa_poly)... passed ( 98)
pot_enthalpy_ice_freezing_first_derivatives_poly (..ng_p_poly)... passed ( 98)

----------------------------------------------------------------------------
Isobaric Melting Enthalpy and Isobaric Evaporation Enthalpy

latentheat_melting............................................... passed ( 98)
latentheat_evap_ct............................................... passed ( 98)
latentheat_evap_t................................................ passed ( 98)

----------------------------------------------------------------------------
Planet Earth properties

grav............................................................. passed ( 98)

----------------------------------------------------------------------------
Density and enthalpy in terms of CT, derived from the exact Gibbs function

enthalpy_ct_exact................................................ passed ( 98)
enthalpy_first_derivatives_ct_exact (h_sa_ct_exact).............. passed ( 98)
enthalpy_first_derivatives_ct_exact (h_ct_ct_exact).............. passed ( 98)
enthalpy_second_derivatives_ct_exact (h_sa_sa_ct_exact).......... passed ( 98)
enthalpy_second_derivatives_ct_exact (h_sa_ct_ct_exact).......... passed ( 98)
enthalpy_second_derivatives_ct_exact (h_ct_ct_ct_exact).......... passed ( 98)

----------------------------------------------------------------------------
Basic thermodynamic properties in terms of in-situ t,
based on the exact Gibbs function

rho_t_exact...................................................... passed ( 98)
pot_rho_t_exact.................................................. passed ( 98)
alpha_wrt_t_exact................................................ passed ( 98)
beta_const_t_exact............................................... passed ( 98)
specvol_t_exact.................................................. passed ( 98)
sound_speed_t_exact.............................................. passed ( 98)
kappa_t_exact.................................................... passed ( 98)
enthalpy_t_exact................................................. passed ( 98)
ct_first_derivatives_wrt_t_exact (ct_sa_wrt_t)................... passed ( 98)
ct_first_derivatives_wrt_t_exact (ct_t_wrt_t).................... passed ( 98)
ct_first_derivatives_wrt_t_exact (ct_p_wrt_t).................... passed ( 98)
chem_potential_water_t_exact..................................... passed ( 98)
t_deriv_chem_potential_water_t_exact............................. passed ( 98)
dilution_coefficient_t_exact..................................... passed ( 98)

----------------------------------------------------------------------------
Library functions of the GSW Toolbox

deltasa_atlas.................................................... passed ( 98)
fdelta........................................................ << failed >>

  Max difference = 7.2483557444241893e-06, limit = 2.7029390553025279e-14
  Max diff (rel) = 3.978247606834969, limit = 1.4835034602778413e-08
  Max at index 60, calcval= 0.00018219971356159167, refval= 0.00017495135781716748
deltasa_atlas_lon_wrapped_high (deltasa_atlas)................... passed ( 98)
deltasa_atlas_lon_wrapped_low (deltasa_atlas).................... passed ( 98)
fdelta_lon_wrapped_high (fdelta).............................. << failed >>

  Max difference = 7.2483557444241893e-06, limit = 2.7029390553025279e-14
  Max diff (rel) = 3.978247606834969, limit = 1.4835034602778413e-08
  Max at index 60, calcval= 0.00018219971356159167, refval= 0.00017495135781716748
fdelta_lon_wrapped_low (fdelta)............................... << failed >>

  Max difference = 7.2483557444241893e-06, limit = 2.7029390553025279e-14
  Max diff (rel) = 3.978247606834969, limit = 1.4835034602778413e-08
  Max at index 60, calcval= 0.00018219971356159167, refval= 0.00017495135781716748

----------------------------------------------------------------------------
Water column properties, based on the 75-term polynomial for specific volume

nsquared (n2).................................................... passed ( 95)
nsquared (p_mid_n2).............................................. passed ( 95)
turner_rsubrho (tu).............................................. passed ( 95)
rsubrhorner_rsubrho (rsubrho).................................... passed ( 95)
p_mid_tursrrner_rsubrho (p_mid_tursr)............................ passed ( 95)
ipv_vs_fnsquared_ratio (ipvfn2).................................. passed ( 95)
ipv_vs_fnsquared_ratio (p_mid_ipvfn2)............................ passed ( 95)
geo_strf_dyn_height........................................... << failed >>

  Max difference = 0.014256831276004078, limit = 3.2645515091189736e-07
  Max diff (rel) = 0.087184740105516592, limit = 1.9963698059796572e-06
  Max at index 96, calcval= -16.352438808384978, refval= -16.338181977108974
geo_strf_dyn_height_pc........................................... passed ( 98)
geo_strf_dyn_height_pc (geo_strf_dyn_height_pc_p_mid)............ passed ( 98)

----------------------------------------------------------------------------
Thermodynamic properties of ice Ih

rho_ice.......................................................... passed (108)
alpha_wrt_t_ice.................................................. passed (108)
specvol_ice...................................................... passed (108)
pressure_coefficient_ice......................................... passed (108)
sound_speed_ice.................................................. passed (108)
kappa_ice........................................................ passed (108)
kappa_const_t_ice................................................ passed (108)
internal_energy_ice.............................................. passed (108)
enthalpy_ice..................................................... passed (108)
entropy_ice...................................................... passed (108)
cp_ice........................................................... passed (108)
chem_potential_water_ice......................................... passed (108)
helmholtz_energy_ice............................................. passed (108)
adiabatic_lapse_rate_ice......................................... passed (108)
pt0_from_t_ice................................................... passed (108)
pt_from_t_ice.................................................... passed (108)
t_from_pt0_ice................................................... passed (108)
pot_enthalpy_from_pt_ice......................................... passed (108)
pt_from_pot_enthalpy_ice......................................... passed (108)
pot_enthalpy_from_pt_ice_poly.................................... passed (108)
pt_from_pot_enthalpy_ice_poly.................................... passed (108)
pressure_freezing_ct............................................. passed ( 30)

----------------------------------------------------------------------------
Thermodynamic interaction between ice and seawater

melting_ice_sa_ct_ratio.......................................... passed (108)
melting_ice_sa_ct_ratio_poly..................................... passed (108)
melting_ice_equilibrium_sa_ct_ratio.............................. passed (108)
melting_ice_equilibrium_sa_ct_ratio_poly......................... passed (108)
melting_ice_into_seawater (..lting_ice_into_seawater_sa_final)... passed (108)
melting_ice_into_seawater (..lting_ice_into_seawater_ct_final)... passed (108)
ice_fraction_to_freeze_seawater (.._freeze_seawater_sa_freeze)... passed (108)
ice_fraction_to_freeze_seawater (.._freeze_seawater_ct_freeze)... passed (108)
ice_fraction_to_freeze_seawater (..on_to_freeze_seawater_w_ih)... passed (108)
frazil_ratios_adiabatic (dsa_dct_frazil)......................... passed (108)
frazil_ratios_adiabatic (dsa_dp_frazil).......................... passed (108)
frazil_ratios_adiabatic (dct_dp_frazil).......................... passed (108)
frazil_ratios_adiabatic_poly (dsa_dct_frazil_poly)............... passed (108)
frazil_ratios_adiabatic_poly (dsa_dp_frazil_poly)................ passed (108)
frazil_ratios_adiabatic_poly (dct_dp_frazil_poly)................ passed (108)
frazil_properties_potential (.._properties_potential_sa_final)... passed (108)
frazil_properties_potential (.._properties_potential_ct_final)... passed (108)
frazil_properties_potential (..roperties_potential_w_ih_final)... passed (108)
frazil_properties_potential_poly (..s_potential_poly_sa_final)... passed ( 91)
frazil_properties_potential_poly (..s_potential_poly_ct_final)... passed ( 91)
frazil_properties_potential_poly (..potential_poly_w_ih_final)... passed ( 91)
frazil_properties (frazil_properties_sa_final)................... passed (108)
frazil_properties (frazil_properties_ct_final)................... passed (108)
frazil_properties (frazil_properties_w_ih_final)................. passed (108)

----------------------------------------------------------------------------
Thermodynamic interaction between seaice and seawater

melting_seaice_sa_ct_ratio....................................... passed (108)
melting_seaice_sa_ct_ratio_poly.................................. passed (108)
melting_seaice_equilibrium_sa_ct_ratio........................... passed (108)
melting_seaice_equilibrium_sa_ct_ratio_poly...................... passed (108)
melting_seaice_into_seawater (..seaice_into_seawater_sa_final)... passed (  0)
melting_seaice_into_seawater (..seaice_into_seawater_ct_final)... passed (  0)
seaice_fraction_to_freeze_seawater (..eeze_seawater_sa_freeze)... passed (108)
seaice_fraction_to_freeze_seawater (..eeze_seawater_ct_freeze)... passed (108)
seaice_fraction_to_freeze_seawater (..to_freeze_seawater_w_ih)... passed (108)

----------------------------------------------------------------------------
Dissolved Gasses

o2sol......................................................... << failed >>

  Max difference = 0.00046798256613556077, limit = 6.2460117078444455e-09
  Max diff (rel) = 0.00014135014436332958, limit = 1.8865545866149133e-09
  Max at index 73, calcval= 331.08035951675288, refval= 331.08082749931901
o2sol_sp_pt...................................................... passed ( 98)

Your installation of the Gibbs SeaWater (GSW) Oceanographic Toolbox has errors !

It seems that the references values in NetCDF file are no-longer correct.

@Alexander-Barth
Copy link
Member Author

Reference values have been updated.
aec9486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant