Fix use after free

MaartenS11 · MaartenS11 · commit 93c6a6648b59 · 2025-03-05T13:58:27.000+01:00
diff --git a/src/Primitives/emulated.cpp b/src/Primitives/emulated.cpp
@@ -692,7 +692,6 @@ std::string get_backward(Module *m, uint32_t fidx) {
     std::stringstream transfer;
     auto *buffer = new char[6];
     sprintf(buffer, "%02" PRIx8 "00%02" PRIx8, interruptTransfer, 1);
-    delete[] buffer;
 
     // TODO: map fidx into primitive index
     if (fidx < ALL_PRIMITIVES) {
@@ -707,6 +706,7 @@ std::string get_backward(Module *m, uint32_t fidx) {
             m->sp -= primitive.t->param_count;
         }
     }
+    delete[] buffer;
     return transfer.str();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -692,7 +692,6 @@ std::string get_backward(Module *m, uint32_t fidx) {`
`692`	`692`	`std::stringstream transfer;`
`693`	`693`	`auto *buffer = new char[6];`
`694`	`694`	`sprintf(buffer, "%02" PRIx8 "00%02" PRIx8, interruptTransfer, 1);`
`695`		`- delete[] buffer;`
`696`	`695`
`697`	`696`	`// TODO: map fidx into primitive index`
`698`	`697`	`if (fidx < ALL_PRIMITIVES) {`
`@@ -707,6 +706,7 @@ std::string get_backward(Module *m, uint32_t fidx) {`
`707`	`706`	`m->sp -= primitive.t->param_count;`
`708`	`707`	`}`
`709`	`708`	`}`
	`709`	`+ delete[] buffer;`
`710`	`710`	`return transfer.str();`
`711`	`711`	`}`
`712`	`712`