Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of Gaussian Datatypes #3

Open
addman2 opened this issue Jun 22, 2023 · 4 comments
Open

Version of Gaussian Datatypes #3

addman2 opened this issue Jun 22, 2023 · 4 comments

Comments

@addman2
Copy link
Contributor

addman2 commented Jun 22, 2023

What version of GDT was used in those examples. I can see basissets are using to_qp method which is not available in orig repo.

@q-posev
Copy link
Member

q-posev commented Jun 22, 2023

Long time ago I used your fork of GDT and even submitted a PR which contains to_qp method but the PR has been ignored ever since ;-)

@addman2
Copy link
Contributor Author

addman2 commented Jun 23, 2023

I see, so with your fork it should work right? I will try to push for the PR to be accepted

@q-posev
Copy link
Member

q-posev commented Nov 9, 2023

@addman2 I saw that you merged my to_qp PR in your fork, but it went into a random branch tolerence something. Do you want to submit a PR to the upstream GDT repo from AiiDA people to put the work you did (and to_qp method) there?

@addman2
Copy link
Contributor Author

addman2 commented Nov 10, 2023

Actually, I would like re-do everything I did to GDT and then I would try to PR everything. Actually it is on my to-do list for next week.

scemama pushed a commit that referenced this issue May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants