Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose setting not passed on to db.getFile #19

Open
hagenw opened this issue Jan 6, 2017 · 6 comments
Open

Verbose setting not passed on to db.getFile #19

hagenw opened this issue Jan 6, 2017 · 6 comments
Assignees

Comments

@hagenw
Copy link
Member

hagenw commented Jan 6, 2017

By setting sim.Verbose = false;, db.getFile() is still used in verbose mode. See for example https://github.com/TWOEARS/examples/blob/master/identification/identify.m#L16

It would be nice if the verbose setting can past to db.getFile() as well. This should be easily possible as bVerbose is already an input parameter to it.

@fietew
Copy link
Member

fietew commented Jan 12, 2017

I am getting errors concerning the old API of the database. After fixing that, I'm getting warnings concerning missing files.

Warning: Download failed
(url=https://dev.qu.tu-berlin.de/projects/twoears-getdata/repository/raw//sound_databases/IEEE_AASP/void/void07.wav.txt),
trying alternative database... 
> In db.downloadFile (line 43)
  In db.getFile (line 85)
  In IdEvalFrame.readOnOffAnnotations (line 121)
  In readAudioFiles (line 95)
  In makeTestSignal (line 15)
  In identify (line 12) 
Warning: Download also failed with alternative database
(url=https://dev.qu.tu-berlin.de/projects/twoears-database/repository/revisions/master/raw//sound_databases/IEEE_AASP/void/void07.wav.txt) 
> In IdEvalFrame.readOnOffAnnotations (line 123)
  In readAudioFiles (line 95)
  In makeTestSignal (line 15)
  In identify (line 12) 
Warning: label annotation file not found: sound_databases/IEEE_AASP/void/void07.wav.txt. Assuming no
events. 
> In IdEvalFrame.readOnOffAnnotations (line 140)
  In readAudioFiles (line 95)
  In makeTestSignal (line 15)
  In identify (line 12) 

I had a look the database and it seems that the label text files for sound_databases/IEEE_AASP/void/ are missing. I will look them up in the internal database.

@fietew
Copy link
Member

fietew commented Jan 12, 2017

They are also missing in the internal database. @kashefy @ivo--t : do you have the data somewhere?
I'm referring to missing label files like e.g. sound_databases/IEEE_AASP/void/void07.wav.txt. It seems, that they are only missing for the void class.

@hagenw
Copy link
Member Author

hagenw commented Jan 12, 2017

The files are missing in the database, because they are supposed to be empty. That was also the main reason for hiding the warning, to avoid that a user is worried.

@hagenw
Copy link
Member Author

hagenw commented Jan 12, 2017

But you are right, maybe it would be better to avoid requesting non-existing files at all.

@kashefy
Copy link
Member

kashefy commented Jan 12, 2017

There are no label files for the void sounds. Our current mechanism for checking that annotation files exist would need to be extended to allow the user to specify when no annotation files are expected.

@ivo--t
Copy link
Member

ivo--t commented Jan 15, 2017

The easy way out here is not to not request the file (as the pipeline has no way of knowing which ones don't have annotation files, beforehand), but to create empty annotation files instead of no files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants