Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation says library is compatible with React 16.8.0, but peerDependencies is { "react": "^17.0.0 || ^18.0.0", "react-dom": "^17.0.0 || ^18.0.0" } #54

Open
cristiano-belloni opened this issue Mar 12, 2024 · 0 comments

Comments

@cristiano-belloni
Copy link

Describe the bug

From package.json of 0.3.1:

"peerDependencies": {
    "react": "^17.0.0 || ^18.0.0",
    "react-dom": "^17.0.0 || ^18.0.0"
  },

Steps to Reproduce the Bug or Issue

  • Try to install the library in a project that has react 16 (> 16.8.0):
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.0 || ^18.0.0" from @tanstack/[email protected]
npm ERR! node_modules/@tanstack/react-store
npm ERR!   @tanstack/react-store@"*" from the root project

Expected behavior

As per README, I'd expect the package to be installed without peer dependencies conflict.

Screenshots or Videos

No response

Platform

  • OS: Windows
  • Browser: N/A, this is a dependency issue
  • Version: N/A, this is a dependency issue

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant