Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Menu Item 需要 onClick 事件参数调整 #2621

Closed
xiaosansiji opened this issue Jul 25, 2023 · 2 comments · Fixed by #2689
Closed

[Menu] Menu Item 需要 onClick 事件参数调整 #2621

xiaosansiji opened this issue Jul 25, 2023 · 2 comments · Fixed by #2689
Assignees
@LeeJim
Labels
API API or Docs changes 🏃🏻 in progress someone is handling

Comments

@xiaosansiji
Copy link
Collaborator

这个功能解决了什么问题

目前的参数：

image

(context: { e: MouseEvent }) 仅仅提供了 event 参数，没有提供实际上可用的业务 ID

你建议的方案是什么

参数 context 对象中新增 value：

(context: { e: MouseEvent, value: MenuValue })
@xiaosansiji xiaosansiji added the API API or Docs changes label Jul 25, 2023
@github-actions
Copy link
Contributor

👋 @xiaosansiji，感谢给 TDesign 提出了 issue。
请根据 issue 模版确保背景信息的完善，我们将调查并尽快回复你。

@github-actions
Copy link
Contributor

♥️ 有劳 @LeeJim @iAmber @qinmudi 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @xiaosansiji 。

@xiaosansiji xiaosansiji added the 🏃🏻 in progress someone is handling label Jul 25, 2023
dexterBo added a commit to dexterBo/tdesign-vue that referenced this issue Aug 14, 2023
@dexterBo
feat(menu-item): click事件参数增加value
c4eda9c 
fix Tencent#2621
This was referenced Aug 14, 2023
Merged
Merged
Merged
xiaosansiji pushed a commit that referenced this issue Aug 15, 2023
@dexterBo
feat(menu-item): click事件参数增加value (#2689)
24b6ccc 
fix #2621
uyarn pushed a commit that referenced this issue Aug 17, 2023
@dexterBo @uyarn
feat(menu-item): click事件参数增加value (#2689)
e0da94c 
fix #2621
LeeJim pushed a commit that referenced this issue Aug 17, 2023
@uyarn @dexterBo
@chaishi @sinbadmaster @xiaosansiji @github-actions
feat(1.6.1): weekly sync update to naruto (#2705)
411c0d1 
* feat(menu-item): click事件参数增加value (#2689)

fix #2621

* feat: add KeyboardEvents to select; fix table some bugs (#2683)

* fix(table): virtual scroll default scroll bar height

* feat(checkbox): support Space checked

* feat(radio): support Space Keyboard to check

* fix(table): e.target.closest might not exist

* test: update snapshots

* feat(select): support keyboard selection

* feat(select): support keyboard

* feat(input): showInput with 0px width

* fix: remove unsued code

* test: update snapshots

* fix(table): drag sort invalid on lazyload

* feat: update common

* feat: update common

* fix(menu): menu的激活菜单项未发生变化时也会触发change (#2693)

fix #2688

* fix(select-input): 多选情况下按下Enter键后触发了focus事件而不是enter事件 (#2694)

fix #2525

* fix(ImageViewer): 前后浏览及关闭浏览重置图片状态 (#2685)

* fix(image-viewer): 前后浏览及关闭浏览重置图片状态

#2679

* fix(image-viewer): 清除关闭时图片状态

* Docs/affix treeselect (#2696)

* fix: affix offsetBottom/offsetTop doc

* fix: tree select keys doc

* fix(select): disable internal filter when remote search (#2699)

* chore: release/1.6.1 (#2692)

* feat: release 1.6.1

* feat: update common

* feat: update common

* feat: update common

* chore: changelog's changes

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: Dexter <[email protected]>
Co-authored-by: sheepluo <[email protected]>
Co-authored-by: sinbadmaster <[email protected]>
Co-authored-by: azhe <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
KMethod pushed a commit to KMethod/tdesign-vue that referenced this issue Aug 25, 2023
@dexterBo
feat(menu-item): click事件参数增加value (Tencent#2689)
02c7334 
fix Tencent#2621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeeJim LeeJim

Labels
API API or Docs changes 🏃🏻 in progress someone is handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(menu-item): click事件参数增加value dexterBo/tdesign-vue
2 participants
@LeeJim @xiaosansiji