Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use asab.web.auth middleware #280

Open
byewokko opened this issue Sep 20, 2023 · 0 comments
Open

Use asab.web.auth middleware #280

byewokko opened this issue Sep 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@byewokko
Copy link
Collaborator

byewokko commented Sep 20, 2023

  • This is a proposal to make authorization and access control more consistent across the ASAB ecosystem.
  • SCA could adapt and extend the asab.web.auth middleware (https://github.com/TeskaLabs/asab/blob/master/asab/web/auth/service.py) instead of having its own fully independent implementation.
  • SCA would override AuthService._authenticate_request method with its own internally handled authentication (without needind to communicate with an external auth server). Also the _fetch_public_keys_if_needed and is_ready methods would need to be overridden.
  • Otherwise, the access control part of the AuthService including the decorators (https://github.com/TeskaLabs/asab/blob/master/asab/web/auth/decorator.py) should be transferrable without changes.
  • This should easily work with the Admin container.
  • Applicability to the Public container needs more investigation.
@byewokko byewokko added the enhancement New feature or request label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant