Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent CMake from downloading content with FetchContent #6787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent CMake from downloading content with FetchContent #6787

wants to merge 1 commit into from

Conversation

FlinkbaumFAU
Copy link

Use nix instead of CMake to download all necessary deps.

@FlinkbaumFAU
Prevent CMake from downloading content with FetchContent
98b7eda 
Use nix instead of CMake to download all necessary deps.
@FlinkbaumFAU
Copy link
Author

Refering #6786

@vvbandeira vvbandeira requested a review from donn February 27, 2025 14:01
@vvbandeira vvbandeira linked an issue Feb 27, 2025 that may be closed by this pull request
Nix build fails #6786
Open
donn
donn approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the bandwidth to test it, but it looks fine. If you say it builds successfully, this can be merged.

@maliberty
Copy link
Member

Please fix the missing DCO (see the details link). In general use git commit -s to sign commits

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2025

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nix build fails
3 participants
@FlinkbaumFAU @maliberty @donn