Use Standard Schema

[yutakobayashidev]

Sometimes, you might want to choose a validation library based on the project. I believe Standard Schema can solve that problem. If it gets accepted by the community, we might be able to eliminate the adapter pattern in the future.

[TheEdoRan]

Absolutely, I've already tried it and it seems very good! Since we support Yup, I'm currently waiting for this PR to be merged to start working on the Standard Schema integration:

• feat: Implement standard schema interface jquense/yup#2258

We also support TypeBox, and here are the author thoughts about Standard Schema. Even if TypeBox will never support Standard Schema by itself, the same author published TypeMap, which apparently solves the problem.

[EskiMojo14]

came here to offer my help with the integration effort :)

The way I see it, there's a choice as to how you want to handle it, as more breaking changes would allow you to simplify a ton of the code:

• just add a new standardAdapter, maybe defaulting to it instead of zodAdapter
• also deprecate the adapters for libraries that support Standard Schema, and remove them in the next major release
• remove the adapters now, cut a major release for it
• remove the concept of an "adapter" altogether, and require Standard Schemas (most breaking, but also would allow significantly simplifying the codebase)
  • probably not an option until Yup supports it

Which approach were you thinking?

[EskiMojo14]

had some time so i put this branch together - each commit roughly maps to a step above, so you can see what it would involve :) by the end of it, it's culled 225 lines of code 🎉

[TheEdoRan]

Hey @EskiMojo14, thanks for your suggestions and work!
My idea is to drop the internal validation adapter system entirely and support just Standard Schema going forward. These changes will be included in a new major version, v8.
The migration path will be quite easy: users will just need to remove the custom validationAdapter when instantiating a safe action client. Users who use Zod as their validation library and didn't explicitly pass the zodAdapter to the client won't need to change anything in their code, since zodAdapter is the default one.
v8 will also remove the deprecated executeOnMount functionality in hooks, here's the discussion:

• Implementing conditional behaviour to useAction hook #266 (reply in thread)

By the way, although Yup still hasn't merged the Standard Schema PR, I think I'll start working on v8 soon and begin releasing beta versions with Standard Schema support.

[EskiMojo14]

great, sounds good 😄 I'll get a PR opened then, then you can have a specific place to add/suggest changes.

[EskiMojo14]

raised #324