Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image caption border overlaps caption at small sizes on Gallery stories #237

Open
phillipadsmith opened this issue Jul 3, 2016 · 6 comments

Comments

@phillipadsmith
Copy link
Member

E.g., http://preview.thetyee.ca/Testing/2015/07/13/Vancouver-Invisible-Money-gallerytest/index.html

gallery-test_clone_of_what__invisible__money_adds_to_vancouver_home_prices___the_tyee

@MrBryan
Copy link
Collaborator

MrBryan commented Jul 5, 2016

fixed with 0fd0f6c . Added clear fix :after fix to those paragraphs

@MrBryan MrBryan closed this as completed Jul 5, 2016
@alexgreen
Copy link
Contributor

@MrBryan I'm seeing some odd markup in the caption:

<div class="carousel-caption caption"><strong></strong>
 <p>2/8 <strong>Seattle</strong>: $510,000. Four beds, 1.1 baths. Size: 2,440 square feet. Lot: 6,938 sq ft. Built in 1951.</p>
</div>

There's and empty <strong></strong> and also a <p> that shouldn't be there (the caption text should just sit directly within the div.
Is this a result of writers typing markup directly into the caption, or is there some other reason for it?

@alexgreen alexgreen reopened this Jul 8, 2016
@alexgreen
Copy link
Contributor

alexgreen commented Jul 8, 2016

The cause of the problem seems to be this css declaration:

@media (max-width: 400px) {
   figure.figure.medium,figure.figure.small {
   max-width:none;
   width: 100%;
   }
   p {
    float:left;
   } 
}

Why do all <p> tags on the page need to float left in narrow views?

@alexgreen
Copy link
Contributor

alexgreen commented Aug 5, 2016

@MrBryan did you have a chance to look at the above 2 comments?

@alexgreen alexgreen self-assigned this Aug 5, 2016
alexgreen added a commit that referenced this issue Sep 22, 2016
alexgreen added a commit that referenced this issue Sep 22, 2016
@alexgreen
Copy link
Contributor

I've commented out the weird rule that floats all p tags left: ab5d18c

But the all the carousel captions still contain incorrect tags. Is this a bug in the bricollage carousel object, @MrBryan ?

@alexgreen
Copy link
Contributor

Same tag issue here: Remove margin-bottom from

tags that appear within figure captions #314
So I assume this is a bric issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants