Fix 1065 to improve code coverage for with_opt.R to 100%
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change filename: testthat style suggets naming "tests/test-with_opt.R" to test functions in a file named "R/with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for "SHINY_PORT" Refs: ThinkR-open#1065
Add a test for get_golem_options() function which was untested before.
- formatting with grk - update comments to explain the test - update the SHINY_PORT test to actually test the behaviour properly - add a new test to check whether print=TRUE works inside with_golem_options()
ilyaZar
changed the title
with_opt.R up to 100%with_opt.R to 100%
|
we'll be watching all the submissions very closely, thanks a lot! |
|
thanks @VincentGuyader |
VincentGuyader
added a commit
that referenced
this pull request
Aug 8, 2023
…1080) * tests: add tests to increase test coverage - change filename: testthat style suggets naming "tests/test-with_opt.R" to test functions in a file named "R/with_opt.R" - improve tests for maintenance mode to see whether it works with setting options in a fresh golem - add tests for "SHINY_PORT" Refs: #1065 * tests: add tests to further increase coverage Add a test for get_golem_options() function which was untested before. * tests: test with_golem_options() with print=TRUE - formatting with grk - update comments to explain the test - update the SHINY_PORT test to actually test the behaviour properly - add a new test to check whether print=TRUE works inside with_golem_options() Co-authored-by: Ilya Zarubin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1065
Done:
change filename:
{testthat}style suggests "test-with_opt.R" as a file name for tests of functions from "R/with_opt.R" 7f5d6d2improve tests for maintenance mode to see whether it works with setting options in a fresh golem 7f5d6d2
add tests for
SHINY_PORT7f5d6d2 and 5d09b49get_golem_optionsis tested by temporarily alteringshiny:::.globalsvariable 1b83332corner case with the
print=TRUE-flag inwith_golem_options()is tested by temporarily overwriting S3-methodshiny:::print.shiny.appobj()5d09b49To-Do / Note keeping:
Full coverage reached for file
R/with_opt.R: