Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder -- PR tc-emphasised tc-strong ... has been reverted #8711

Open
pmario opened this issue Oct 30, 2024 · 2 comments
Open

Reminder -- PR tc-emphasised tc-strong ... has been reverted #8711

pmario opened this issue Oct 30, 2024 · 2 comments

Comments

@pmario
Copy link
Member

pmario commented Oct 30, 2024

While the tests are easy to fix, on reflection I would like to revert this PR so that we can experiment a little more.

The idea I am exploring is to make the element widget look at a variable tv-add-emphasis-classes (or something) to determine whether to add these classes. Thus wikitext authors would opt-in to the new behaviour if required. This might also involve adding a generic mechanism for setting global variables.

Originally posted by @Jermolene in #8163 (comment)

Just a reminder, so we do not forget about it.

@Jermolene
Copy link
Member

Thanks @pmario – perhaps this is something you would like to work on?

@Jermolene
Copy link
Member

Happy to discuss it further to hammer out the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants