Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation issues with non-fullscreen embedding in partner sites #49

Closed
lottallegra opened this issue Nov 8, 2016 · 9 comments
Closed
Assignees
Labels

Comments

@lottallegra
Copy link

lottallegra commented Nov 8, 2016

Menu Icon not intuitive:
Menu not visible, when iframe width is not full screen width on large display (width = 735, for example):

menu icon

Menu covers whole Map:
The menu entries take up the whole width oft he iframe when opened and compleately cover up the underlying map PLUS there is no „BACK TO MAP“ button visible. Users might be lost in navigation. Idea: maximum menu entry width is around 80% so that part oft he underlying map remains visible and users can go back to map view by clicking on the still visible part oft he map.
menu

@josefkreitmayer josefkreitmayer changed the title Navigation issues Navigation issues with non-fullscreen embedding in partner sites Nov 8, 2016
@josefkreitmayer josefkreitmayer added this to the website-integration milestone Nov 8, 2016
@josefkreitmayer
Copy link
Member

Hello @lottallegra thank you for your feedback and request. That is a vital part of the development process.

I am going to divide different issues apart, so they can be taken on independently. Thank you for the screenshots and good reporting!!!
In the next days and we will go through all of them and decide what we can resolve immediately!

@josefkreitmayer
Copy link
Member

josefkreitmayer commented Nov 8, 2016

@josefkreitmayer
Copy link
Member

@lottallegra the main issue here is, that the mobile mode which has the properties you describe is set to early, so that it is already enabled from a with of ~800 px. We will try different settings for that in the next days.

Once that setting is changed, the menu and everything else will look normal.

@josefkreitmayer
Copy link
Member

josefkreitmayer commented Nov 9, 2016

@species can you prioritize this issue? Once resolved, we can move forward to rollout the process for partnersite integration. I assume, that subsequent feedback to the partnersite integration will mostly be enhancements or minor usability bugs.

Apart from resolving this issue, I would suggest, we decide what to resolve first, short before the next sprint planning.

@josefkreitmayer
Copy link
Member

@species let´s set the breakpoint for mobile mode with 640 epx.

I found the measurement here. It should fit for most smartphones in the market. Phones with HD screen will still be able to use the general menu, as the resolution is so very high

@species
Copy link
Contributor

species commented Nov 9, 2016

set to 640px for all 3 repositories.

@species species closed this as completed Nov 9, 2016
@josefkreitmayer
Copy link
Member

@lottallegra can you test in the inkota-Site, now it should work. Thank you!

@lottallegra
Copy link
Author

map

Its better, as the menu is not covering the whole map anymore. In some cases, however (as shown on the picture above), the menu is still covering about half of the map. The menu doesn't close entirely either, the only option is to click on different menu items so that a smaller menu popps up, which covers less of the map. Is it possible to make the menu close when one clicks on the map?

@josefkreitmayer
Copy link
Member

The issue with the menu covering too much space is now moved here: susy-partners#18, as the original issue is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants