Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose DiscoverNodesOnStart and DiscoverNodesInterval #38

Open
mhmtszr opened this issue Oct 3, 2023 · 2 comments
Open

Expose DiscoverNodesOnStart and DiscoverNodesInterval #38

mhmtszr opened this issue Oct 3, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@mhmtszr
Copy link
Member

mhmtszr commented Oct 3, 2023

If we set less node urls than existing, our request will be always forwarded to these nodes. We want to use other nodes too.

We need to configure DiscoverNodesOnStart and DiscoverNodesInterval configs, we just need to add these configs to elasticsearch.NewClient function.

@mhmtszr mhmtszr added the good first issue Good for newcomers label Oct 3, 2023
@oguzhaneren
Copy link

You may consider exposing all internal elastic client configurations to go-dcp-elasticsearch clients.

it will be good if I can overwrite any parameters here:

https://github.com/Trendyol/go-dcp-elasticsearch/blob/master/elasticsearch/client/client.go#L11

@bilalislam
Copy link

bilalislam commented Nov 30, 2023

btw , if I set one url or lb for DiscoverNodesOnStart then I got error like dialing to the given TCP address timed out.

its fixed when set to true in config.yml Because it was configured as DiscoverNodesOnStart: !config.Elasticsearch.DisableDiscoverNodesOnStart

Keep in mind that 💯

@SevcanDogramaci SevcanDogramaci removed their assignment Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants