-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make this site private - not working in Chrome and Opera #17514
Comments
Maybe you can implement, like the 'ghost-admin-api-session':
|
This issue is currently awaiting triage from @daniellockyer. We're having a busy time right now, but we'll update this issue ASAP. If you have any more information to help us triage faster please leave us some comments. Thank you for understanding 🙂 |
In core/frontend/apps/private-blogging/lib/middleware.js: ´´´
´´´ and all is fine! |
This issue is currently awaiting triage from @daniellockyer. We're having a busy time right now, but we'll update this issue ASAP. If you have any more information to help us triage faster please leave us some comments. Thank you for understanding 🙂 |
Hey there, thank you so much for the detailed bug report. That does look like something that shouldn't happen! A PR to fix this issue would be very welcome 🙂 |
"Make this site private" - not working in Chrome and Opera Closes TryGhost#17514
I have made the PR |
Hi, I am facing the same issue in the latest version of Ghost, unable to login to the private site using Chrome based browsers. |
It's nearly three month later ... an nothing happened. But for me it closed, because I'm working locally :-) |
yeah, they didn't care to merge it. but I appreciate you for your troubleshooting and the fix. I think just a rerun would be required to pass the build, otherwise the PR is already approved: https://github.com/TryGhost/Ghost/actions/runs/6057836235/job/16821076886?pr=17938 |
I have made my first PR.
I think the 2. one failed: Merge branch 'main' into joe-blocher-patch-1 <ae0f64e>
I don't really know what is for and how I can delete this PR...
… Am 16.10.2023 um 08:45 schrieb Hussain ***@***.***>:
It's nearly three month later ... an nothing happened. But for me it closed, because I'm working locally :-) https://forum.ghost.org/t/make-this-site-private-not-working/39938 <https://forum.ghost.org/t/make-this-site-private-not-working/39938>
yeah, they didn't care to merge it. but I appreciate you for your troubleshooting and the fix.
I think just a rerun would be required to pass the build, otherwise the PR is already approved:
https://github.com/TryGhost/Ghost/actions/runs/6057836235/job/16821076886?pr=17938 <https://github.com/TryGhost/Ghost/actions/runs/6057836235/job/16821076886?pr=17938>
<https://user-images.githubusercontent.com/4962633/275414297-2abc6c33-ed0c-442d-9e81-9cdbd0e405cd.png>
—
Reply to this email directly, view it on GitHub <#17514 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWHNLAX5ONSU2FFFUG6MRN3X7TJZDANCNFSM6AAAAAA2ZM7QIU>.
You are receiving this because you modified the open/close state.
|
Maybe @daniellockyer can help |
fixes #17514 - good explanation in #17938 (comment) - fixes setting the private mode cookie in stricter browsers for local development
You did't fix the error: Make this site private - not working not working in Chrome and Opera SOLUTION - it told you in August 2023 and I have made the PR!versions/5.82.2/core/frontend/apps/private-blogging/lib/middleware.js `const privateBlogging = {
|
The pull request still not merged in version 5.82.2: Why not? |
What makes you say the PR wasn't merged? The commit shows that it's been in releases starting from 5.70.0. |
I've downloaded the code: |
The code being the same does not mean your PR was not merged. In this case it looks like this change ended up possibly breaking something else so it was reverted: |
OK so that means it is still a problem. I am running 5.79.6 (released Feb 26) and cannot make the site private because of this bug. What's the ETA on solving this? |
My solution: |
Hey guys, any update on this one? I couldn't access the links behind why the commit was reverted. So not sure on the details or complexity of the bug, is there any progress towards figuring it out? Thanks, and I'm a huge Ghost fan 😊 |
Downloaded version 5.89.1 - this bug still not fixed You have to change only 2 lines in your code. |
Issue Summary
Change or delete the row 58:
versions/5.54.4/core/frontend/apps/private-blogging/lib/middleware.js
Or you can delete the row 58 because sameSite: 'Lax' is the default value.
You can't code 'secure' within an object - secure: true will not work.
Works now in Chrome and Opera.
See https://web.dev/i18n/en/samesite-cookies-explained
Steps to Reproduce
See https://forum.ghost.org/t/make-this-site-private-not-working/39938/1
Ghost Version
5.54.4
Node.js Version
v18.15.0
How did you install Ghost?
local, macos
Database type
SQLite3
Browser & OS version
No response
Relevant log / error output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: