Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation strips the subdirectory name while trying to create a navigation item #19795

Closed
1 task done
truekasun opened this issue Mar 4, 2024 · 7 comments
Closed
1 task done
Labels
bug [triage] something behaving unexpectedly

Comments

@truekasun
Copy link
Contributor

Issue Summary

Navigation strips the subdirectory name when trying to create a navigation item.

Let's say:

When trying to create a navigation item with the target "https://domain.com/blog/about",
The editor strips away the word "blog" from the navigation item URL (as soon as the user clicks away from the URL field)

Steps to Reproduce

msedge_0fdMpJHvV0.mp4

Ghost Version

5.80.0

Node.js Version

18.19.1

How did you install Ghost?

Self-hosted | Subdirectory | Ubuntu 20.04.6 (LTS)

Database type

MySQL 8

Browser & OS version

Microsoft Edge 122.0.2365.52 | Mozilla Firefox 123.0

Relevant log / error output

No browser console errors are present

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Mar 4, 2024
@truekasun truekasun changed the title Navigation strips the subdirectory name when trying to create a navigation item Navigation strips the subdirectory name while trying to create a navigation item Mar 4, 2024
@daniellockyer daniellockyer added bug [triage] something behaving unexpectedly needs:triage [triage] this needs to be triaged by the Ghost team and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Apr 1, 2024
@github-actions github-actions bot removed the needs:triage [triage] this needs to be triaged by the Ghost team label Apr 1, 2024
@daniellockyer
Copy link
Member

Hey there, thank you so much for the bug report.

That does look like something that shouldn't happen! A PR to fix this issue would be very welcome 🙂

@truekasun
Copy link
Contributor Author

Additional info: This is happening on both Primary & Secondary Navigation options.

@RonakSurana-2001
Copy link

Can You assign this issue to me. I am interested to work on it
Thanks

@ningthoujamSwamikumar
Copy link

ningthoujamSwamikumar commented Oct 7, 2024

Hi @daniellockyer . I am Interested. Anyone working on this? Please assign this to me. I will work on it. Thanks.

@cathysarisky
Copy link
Contributor

Hey @truekasun ,

Thanks for the video - that made the problem super clear. Or at least, it should have. I am trying to replicate this, and I can't.

Would you mind checking on Ghost 5.98 or 5.97 to see if the problem is still there? When I set up Ghost as a subsite, the url fields all include the subsite path, and editing or adding new ones doesn't stripe the path, in my setup.

@truekasun
Copy link
Contributor Author

Hey @truekasun ,

Thanks for the video - that made the problem super clear. Or at least, it should have. I am trying to replicate this, and I can't.

Would you mind checking on Ghost 5.98 or 5.97 to see if the problem is still there? When I set up Ghost as a subsite, the url fields all include the subsite path, and editing or adding new ones doesn't stripe the path, in my setup.

Hi @cathysarisky ,

Sure, I'll try this and will update the findings here. I still have a few environments that I haven't updated yet.

@truekasun
Copy link
Contributor Author

@cathysarisky @daniellockyer
I have checked this issue on v5.98.1 and it seems it's already fixed. Guess it's safe to close this issue.

Thank you @cathysarisky for giving it a shot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Development

No branches or pull requests

5 participants